You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by attilapiros <gi...@git.apache.org> on 2018/02/12 19:44:17 UTC
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
GitHub user attilapiros opened a pull request:
https://github.com/apache/spark/pull/20589
[SPARK-23394][UI] In RDD storage page show the executor addresses instead of the IDs
## What changes were proposed in this pull request?
Extending RDD storage page to show executor addresses in the block table.
## How was this patch tested?
Manually:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/attilapiros/spark SPARK-23394
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20589.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20589
----
commit 3ccad539410615156dea2ee83ad7d7841f520a46
Author: “attilapiros” <pi...@...>
Date: 2018-02-12T19:17:32Z
initial version
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20589
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20589
jenkins retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87387/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20589#discussion_r167884170
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -76,7 +76,8 @@ private[ui] class RDDPage(parent: SparkUITab, store: AppStatusStore) extends Web
rddStorageInfo.partitions.get,
blockPageSize,
blockSortColumn,
- blockSortDesc)
+ blockSortDesc,
+ store.executorList(false))
--- End diff --
As we have a fallback to executorId we can do that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87387/testReport)** for PR 20589 at commit [`eee987a`](https://github.com/apache/spark/commit/eee987ad4344f22696abf9338a36bb27bdf8db66).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20589#discussion_r168100501
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -198,7 +200,10 @@ private[ui] class BlockDataSource(
rddPartition.storageLevel,
rddPartition.memoryUsed,
rddPartition.diskUsed,
- rddPartition.executors.mkString(" "))
+ rddPartition.executors
+ .sorted
+ .map { id => executorIdToAddress.get(id).getOrElse(id) }
--- End diff --
nit: should we sort by address?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87447/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87343/testReport)** for PR 20589 at commit [`3ccad53`](https://github.com/apache/spark/commit/3ccad539410615156dea2ee83ad7d7841f520a46).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/20589#discussion_r168141926
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -198,7 +200,10 @@ private[ui] class BlockDataSource(
rddPartition.storageLevel,
rddPartition.memoryUsed,
rddPartition.diskUsed,
- rddPartition.executors.mkString(" "))
+ rddPartition.executors
+ .sorted
+ .map { id => executorIdToAddress.get(id).getOrElse(id) }
--- End diff --
ok ,done
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20589
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87441/testReport)** for PR 20589 at commit [`cdc5168`](https://github.com/apache/spark/commit/cdc5168f721eed6b3634edd9eaaae8965b295ceb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87430/testReport)** for PR 20589 at commit [`cdc5168`](https://github.com/apache/spark/commit/cdc5168f721eed6b3634edd9eaaae8965b295ceb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87344/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87360/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87360/testReport)** for PR 20589 at commit [`3ccad53`](https://github.com/apache/spark/commit/3ccad539410615156dea2ee83ad7d7841f520a46).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87441/testReport)** for PR 20589 at commit [`cdc5168`](https://github.com/apache/spark/commit/cdc5168f721eed6b3634edd9eaaae8965b295ceb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87343/testReport)** for PR 20589 at commit [`3ccad53`](https://github.com/apache/spark/commit/3ccad539410615156dea2ee83ad7d7841f520a46).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87395/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87395/testReport)** for PR 20589 at commit [`ef69450`](https://github.com/apache/spark/commit/ef69450ff382d6d6a8d75a74a2473f6973bc6d71).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20589
Merging to master / 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87420/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87430/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20589#discussion_r167880936
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -76,7 +76,8 @@ private[ui] class RDDPage(parent: SparkUITab, store: AppStatusStore) extends Web
rddStorageInfo.partitions.get,
blockPageSize,
blockSortColumn,
- blockSortDesc)
+ blockSortDesc,
+ store.executorList(false))
--- End diff --
Should this only list active executors?
Theoretically you shouldn't have any blocks stored on dead executors.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87395/testReport)** for PR 20589 at commit [`ef69450`](https://github.com/apache/spark/commit/ef69450ff382d6d6a8d75a74a2473f6973bc6d71).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20589#discussion_r167666944
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -243,7 +246,8 @@ private[ui] class BlockPagedTable(
rddPartitions,
pageSize,
sortColumn,
- desc)
+ desc,
+ executorSummaries.map(ex => (ex.id, ex.hostPort)).toMap)
--- End diff --
Probably a good idea to keep the map sorted by the executor id, somehow.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by kiszk <gi...@git.apache.org>.
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20589
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87441/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20589
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87360/testReport)** for PR 20589 at commit [`3ccad53`](https://github.com/apache/spark/commit/3ccad539410615156dea2ee83ad7d7841f520a46).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87344/testReport)** for PR 20589 at commit [`3ccad53`](https://github.com/apache/spark/commit/3ccad539410615156dea2ee83ad7d7841f520a46).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87420/testReport)** for PR 20589 at commit [`cdc5168`](https://github.com/apache/spark/commit/cdc5168f721eed6b3634edd9eaaae8965b295ceb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87387/testReport)** for PR 20589 at commit [`eee987a`](https://github.com/apache/spark/commit/eee987ad4344f22696abf9338a36bb27bdf8db66).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87344/testReport)** for PR 20589 at commit [`3ccad53`](https://github.com/apache/spark/commit/3ccad539410615156dea2ee83ad7d7841f520a46).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87420/testReport)** for PR 20589 at commit [`cdc5168`](https://github.com/apache/spark/commit/cdc5168f721eed6b3634edd9eaaae8965b295ceb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87386/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by attilapiros <gi...@git.apache.org>.
Github user attilapiros commented on the issue:
https://github.com/apache/spark/pull/20589
jenkins retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87413/testReport)** for PR 20589 at commit [`ef69450`](https://github.com/apache/spark/commit/ef69450ff382d6d6a8d75a74a2473f6973bc6d71).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20589
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20589
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87386/testReport)** for PR 20589 at commit [`ec160aa`](https://github.com/apache/spark/commit/ec160aaaad3c3baef07deb93f9c733c88be35fe0).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20589: [SPARK-23394][UI] In RDD storage page show the ex...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20589#discussion_r167666745
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -198,7 +200,7 @@ private[ui] class BlockDataSource(
rddPartition.storageLevel,
rddPartition.memoryUsed,
rddPartition.diskUsed,
- rddPartition.executors.mkString(" "))
+ rddPartition.executors.map(id => executorIdToAddress.get(id).getOrElse(id)).mkString(" "))
--- End diff --
`.map { id => ... }`
Also in other places.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87447/testReport)** for PR 20589 at commit [`75bb8c5`](https://github.com/apache/spark/commit/75bb8c5120fa58608560406bc714739f2caa8c87).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87447/testReport)** for PR 20589 at commit [`75bb8c5`](https://github.com/apache/spark/commit/75bb8c5120fa58608560406bc714739f2caa8c87).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87386/testReport)** for PR 20589 at commit [`ec160aa`](https://github.com/apache/spark/commit/ec160aaaad3c3baef07deb93f9c733c88be35fe0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87430/testReport)** for PR 20589 at commit [`cdc5168`](https://github.com/apache/spark/commit/cdc5168f721eed6b3634edd9eaaae8965b295ceb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20589
**[Test build #87413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87413/testReport)** for PR 20589 at commit [`ef69450`](https://github.com/apache/spark/commit/ef69450ff382d6d6a8d75a74a2473f6973bc6d71).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87413/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20589: [SPARK-23394][UI] In RDD storage page show the executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87343/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org