You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2016/01/24 19:55:31 UTC

svn commit: r1726537 - /maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/parser/module/AbstractParserModule.java

Author: hboutemy
Date: Sun Jan 24 18:55:30 2016
New Revision: 1726537

URL: http://svn.apache.org/viewvc?rev=1726537&view=rev
Log:
[DOXIA-527] reworked constructors since misleading (String, String, String) with (String, String..., String)

Modified:
    maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/parser/module/AbstractParserModule.java

Modified: maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/parser/module/AbstractParserModule.java
URL: http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/parser/module/AbstractParserModule.java?rev=1726537&r1=1726536&r2=1726537&view=diff
==============================================================================
--- maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/parser/module/AbstractParserModule.java (original)
+++ maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/parser/module/AbstractParserModule.java Sun Jan 24 18:55:30 2016
@@ -41,7 +41,7 @@ public abstract class AbstractParserModu
      */
     public AbstractParserModule()
     {
-        this( null, (String[]) null, null );
+        this( null, null, (String[]) null );
     }
 
     /**
@@ -55,9 +55,9 @@ public abstract class AbstractParserModu
     /**
      * Constructor with same value for parser id and source directory.
      */
-    public AbstractParserModule( String parserId, String... extensions )
+    public AbstractParserModule( String parserId, String extension )
     {
-        this( parserId, extensions, parserId );
+        this( parserId, parserId, new String[] { extension } );
     }
 
     /**
@@ -65,6 +65,7 @@ public abstract class AbstractParserModu
      * @param extension not null
      * @param parserId not null
      * @since 1.1.1
+     * @deprecated can cause confusion with constructor with multiple extensions
      */
     protected AbstractParserModule( String sourceDirectory, String extension, String parserId )
     {
@@ -76,11 +77,11 @@ public abstract class AbstractParserModu
 
     /**
      * @param sourceDirectory not null
+     * @param parserId not null (usually equals sourceDirectory)
      * @param extensions not null
-     * @param parserId not null
      * @since 1.7
      */
-    protected AbstractParserModule( String sourceDirectory, String[] extensions, String parserId )
+    protected AbstractParserModule( String sourceDirectory, String parserId, String... extensions )
     {
         super();
         this.sourceDirectory = sourceDirectory;