You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/03 15:49:06 UTC
[GitHub] [flink] RocMarshal opened a new pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
RocMarshal opened a new pull request #13056:
URL: https://github.com/apache/flink/pull/13056
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese*
## Brief change log
*Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese*
*The page url is https://ci.apache.org/projects/flink/flink-docs-release-1.11/zh/monitoring/debugging_event_time.html*
*The markdown file is located in flink/docs/monitoring/debugging_event_time.zh.md.*
## Verifying this change
*(Please pick either of the following options)*
This change is a pure documentation work without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668313570
Hi, @klion26 .
Could you help me to review this PR if you have free time?
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668098886
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec (Mon Aug 03 15:51:39 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668101628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-670029804
Hi, @klion26
Thank you so much for your review.
I made some changes based on your suggestions. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668987047
@RocMarshal thanks for your contribution. the pr is under my radar now, will review it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #13056:
URL: https://github.com/apache/flink/pull/13056#discussion_r465674175
##########
File path: docs/monitoring/debugging_event_time.zh.md
##########
@@ -25,33 +25,28 @@ under the License.
* ToC
{:toc}
-## Monitoring Current Event Time
+<a name="monitoring-current-event-time"></a>
-Flink's [event time]({{ site.baseurl }}/dev/event_time.html) and watermark support are powerful features for handling
-out-of-order events. However, it's harder to understand what exactly is going on because the progress of time
-is tracked within the system.
+## 监控当前事件时间（Event Time）
-Low watermarks of each task can be accessed through Flink web interface or [metrics system]({{ site.baseurl }}/monitoring/metrics.html).
+Flink 的[事件时间]({% link dev/event_time.zh.md %})和 watermark 支持对于处理乱序事件是十分强大的特性。然而，由于是系统内部跟踪了时间进度，所以很难理解究竟发生了什么。
Review comment:
`由于是系统内部跟踪时间进度，所以很难了解究竟正在发生了什么` 这样会好一些吗？
##########
File path: docs/monitoring/debugging_event_time.zh.md
##########
@@ -25,33 +25,28 @@ under the License.
* ToC
{:toc}
-## Monitoring Current Event Time
+<a name="monitoring-current-event-time"></a>
-Flink's [event time]({{ site.baseurl }}/dev/event_time.html) and watermark support are powerful features for handling
-out-of-order events. However, it's harder to understand what exactly is going on because the progress of time
-is tracked within the system.
+## 监控当前事件时间（Event Time）
-Low watermarks of each task can be accessed through Flink web interface or [metrics system]({{ site.baseurl }}/monitoring/metrics.html).
+Flink 的[事件时间]({% link dev/event_time.zh.md %})和 watermark 支持对于处理乱序事件是十分强大的特性。然而，由于是系统内部跟踪了时间进度，所以很难理解究竟发生了什么。
-Each Task in Flink exposes a metric called `currentInputWatermark` that represents the lowest watermark received
-by this task. This long value represents the "current event time".
-The value is calculated by taking the minimum of all watermarks received by upstream operators. This means that
-the event time tracked with watermarks is always dominated by the furthest-behind source.
+可以通过 Flink web 界面或[指标系统]({% link monitoring/metrics.zh.md %})访问 task 的 low watermarks。
-The low watermark metric is accessible **using the web interface**, by choosing a task in the metric tab,
-and selecting the `<taskNr>.currentInputWatermark` metric. In the new box you'll now be able to see
-the current low watermark of the task.
+Flink 中的 task 通过调用 `currentInputWatermark` 方法公开一个指标，该指标表示当前 task 所接收到的 the lowest watermark。这个 long 类型值表示“当前事件时间”。该值通过获取上游算子收到的所有 watermarks 的最小值来计算。这意味着用 watermarks 跟踪的事件时间总是由最落后的 source 控制。
Review comment:
这里我不完全确定 ”公开一个指标“ 是否有习惯这么描述，因为我听到更多的是 ”暴露一个指标“ 。如果确定这个是一个习惯描述的话，也可以
##########
File path: docs/monitoring/debugging_event_time.zh.md
##########
@@ -25,33 +25,28 @@ under the License.
* ToC
{:toc}
-## Monitoring Current Event Time
+<a name="monitoring-current-event-time"></a>
-Flink's [event time]({{ site.baseurl }}/dev/event_time.html) and watermark support are powerful features for handling
-out-of-order events. However, it's harder to understand what exactly is going on because the progress of time
-is tracked within the system.
+## 监控当前事件时间（Event Time）
-Low watermarks of each task can be accessed through Flink web interface or [metrics system]({{ site.baseurl }}/monitoring/metrics.html).
+Flink 的[事件时间]({% link dev/event_time.zh.md %})和 watermark 支持对于处理乱序事件是十分强大的特性。然而，由于是系统内部跟踪了时间进度，所以很难理解究竟发生了什么。
-Each Task in Flink exposes a metric called `currentInputWatermark` that represents the lowest watermark received
-by this task. This long value represents the "current event time".
-The value is calculated by taking the minimum of all watermarks received by upstream operators. This means that
-the event time tracked with watermarks is always dominated by the furthest-behind source.
+可以通过 Flink web 界面或[指标系统]({% link monitoring/metrics.zh.md %})访问 task 的 low watermarks。
-The low watermark metric is accessible **using the web interface**, by choosing a task in the metric tab,
-and selecting the `<taskNr>.currentInputWatermark` metric. In the new box you'll now be able to see
-the current low watermark of the task.
+Flink 中的 task 通过调用 `currentInputWatermark` 方法公开一个指标，该指标表示当前 task 所接收到的 the lowest watermark。这个 long 类型值表示“当前事件时间”。该值通过获取上游算子收到的所有 watermarks 的最小值来计算。这意味着用 watermarks 跟踪的事件时间总是由最落后的 source 控制。
-Another way of getting the metric is using one of the **metric reporters**, as described in the documentation
-for the [metrics system]({{ site.baseurl }}/monitoring/metrics.html).
-For local setups, we recommend using the JMX metric reporter and a tool like [VisualVM](https://visualvm.github.io/).
+**使用 web 界面**可以访问 low watermark 指标，在指标选项卡中选择一个 task，然后选择 ```<taskNr>.currentInputWatermark``` 指标。在新的显示框中，你可以看到此 task 的当前 low watermark。
+获取指标的另一种方式是使用**指标报告器**之一，如[指标系统]({% link monitoring/metrics.zh.md %})文档所述。对于本地集群设置，我们推荐使用 JMX 指标报告器和类似于 [VisualVM](https://visualvm.github.io/) 的工具。
-## Handling Event Time Stragglers
- - Approach 1: Watermark stays late (indicated completeness), windows fire early
- - Approach 2: Watermark heuristic with maximum lateness, windows accept late data
+<a name="handling-event-time-stragglers"></a>
+
+## 处理散乱的事件时间
+
+ - 方式 1：Watermark 延迟（表明完整性），窗口提前触发
Review comment:
感觉这句话读起来有点不太完整的样子 -- 不太明白这句话的意思，不过我暂时没有一个很好的翻译。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13056:
URL: https://github.com/apache/flink/pull/13056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668101628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5134",
"triggerID" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"triggerType" : "PUSH"
}, {
"hash" : "c5d0f281b1b2dc060933f522ec987845641e55ae",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5257",
"triggerID" : "c5d0f281b1b2dc060933f522ec987845641e55ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5d0f281b1b2dc060933f522ec987845641e55ae Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5257)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668101628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5134",
"triggerID" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5134)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-671404910
Thanks a lot for the contribution @RocMarshal and the review @klion26 !
I'm merging the change now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13056: [FLINK-18798][docs-zh] Translate "Debugging Windows & Event Time" page of "Debugging & Monitoring" into Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13056:
URL: https://github.com/apache/flink/pull/13056#issuecomment-668101628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5134",
"triggerID" : "8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec",
"triggerType" : "PUSH"
}, {
"hash" : "c5d0f281b1b2dc060933f522ec987845641e55ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c5d0f281b1b2dc060933f522ec987845641e55ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b85e68eedac9bcc99cbdfe886df0adfe39dc2ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5134)
* c5d0f281b1b2dc060933f522ec987845641e55ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org