You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/24 18:32:59 UTC
Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Included headers to make `stout/windows.hpp` standalone.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
Diff: https://reviews.apache.org/r/39620/diff/
Testing
-------
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Re: Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/#review104077
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 24, 2015, 9:32 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39620/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2015, 9:32 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Included headers to make `stout/windows.hpp` standalone.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
>
> Diff: https://reviews.apache.org/r/39620/diff/
>
>
> Testing
> -------
>
> `make check` from CMake on OS X 10.10.
> `make check` from Autotools on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
> PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/#review110025
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 20)
<https://reviews.apache.org/r/39620/#comment169780>
We can pull this directory include out below.
- Joris Van Remoortere
On Dec. 11, 2015, 8 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39620/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2015, 8 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Included headers to make `stout/windows.hpp` standalone.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 9f846738da95d7a32eb6aea2eea16f58af4cfebd
>
> Diff: https://reviews.apache.org/r/39620/diff/
>
>
> Testing
> -------
>
> `make check` from CMake on OS X 10.10.
> `make check` from Autotools on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
> PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 8 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Included headers to make `stout/windows.hpp` standalone.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 9f846738da95d7a32eb6aea2eea16f58af4cfebd
Diff: https://reviews.apache.org/r/39620/diff/
Testing
-------
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Re: Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 7:56 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Included headers to make `stout/windows.hpp` standalone.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39620/diff/
Testing
-------
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Re: Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:13 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Included headers to make `stout/windows.hpp` standalone.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39620/diff/
Testing
-------
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Re: Review Request 39620: Windows: Included headers to make
`stout/windows.hpp` standalone.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 5:57 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
Windows: Included headers to make `stout/windows.hpp` standalone.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39620/diff/
Testing
-------
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer