You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/05/21 14:22:29 UTC

[GitHub] [spark] panbingkun opened a new pull request, #41246: [SPARK-43599][CONNECT][BUILD] Upgrade buf to v1.19.0

panbingkun opened a new pull request, #41246:
URL: https://github.com/apache/spark/pull/41246

   ### What changes were proposed in this pull request?
   The pr aims to upgrade buf from 1.18.0 to 1.19.0
   
   ### Why are the changes needed?
   Release Notes: https://github.com/bufbuild/buf/releases
   
   - Fix issue in buf build and buf generate where the use of type filtering (via --type flags) would cause the resulting image to have no source code info, even when --exclude-source-info was not specified. The main impact of the bug was that
   generated code would be missing comments.
   - Fix issue in buf curl when using --user or --netrc that would cause a malformed Authorization header to be sent.
   
   https://github.com/bufbuild/buf/compare/v1.18.0...v1.19.0
   
   Manually test: dev/connect-gen-protos.sh
   This upgrade will not change the generated files.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Manually test and Pass GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #41246: [SPARK-43599][CONNECT][BUILD] Upgrade buf to v1.19.0

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41246: [SPARK-43599][CONNECT][BUILD] Upgrade buf to v1.19.0
URL: https://github.com/apache/spark/pull/41246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org