DO NOT REPLY [Bug 37293] New: - [configuration] Output format of FielConfiguration classes

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37293>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37293

           Summary: [configuration] Output format of FielConfiguration
                    classes
           Product: Commons
           Version: 1.1 Final
          Platform: Other
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Configuration
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: Kay.Doebl@gabo.de


I am using Commons Configuration 1.1.

Saving 'FielConfiguration's the configuration files will be overwritten every time.
Bad if you have formatted them with descriptions and comments ... but this is
not so important.

Not so good is, that in the class:

PropertiesConfiguration:
'\n' is used as "line separator" and not the "System.getProperty("line.separator")".
So, on Windows systems the configuration files are badly readable.

XMLConfiguration:
The encoding is not looped though to the encoding in the XML head declaration.
Every time "UTF-8" is set (<?xml version="1.0" encoding="UTF-8"?>)
I would prefer that my encoding (setEncoding()) is reflected in the XML document.

Is there a reason that it is implemented like you do?

Attached are patches which would resolve the problems (if you want):

PropertiesConfiguration.java:

properties_lineseparator.patch

136a137,138
>     private static final String lineSeparator =
System.getProperty("line.separator");
> 
344c346
<                 out.write("\n");
---
>                 out.write(lineSeparator);
349c351
<             out.write("\n");
---
>             out.write(lineSeparator);
486c488
<             write('\n');
---
>             write(lineSeparator);
511c513
<             write("# " + comment + "\n");
---
>             write("# " + comment + lineSeparator);


XMLConfiguration.java:

XML_encoding.patch
446a447
>             transformer.setOutputProperty(OutputKeys.ENCODING, getEncoding());

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org