[GitHub] [tvm] yangulei commented on a diff in pull request #12151: [BYOC-DNNL] add post_sum pattern

[GitBox <gi...@apache.org>]

yangulei commented on code in PR #12151:
URL: https://github.com/apache/tvm/pull/12151#discussion_r931740353


##########
python/tvm/relay/op/contrib/dnnl.py:
##########
@@ -305,6 +395,12 @@ def pattern_table():
     dnnl_patterns = list()
     dnnl_patterns.append(make_qnn_conv2d_pattern())
     dnnl_patterns.append(make_qnn_dense_pattern())
+    dnnl_patterns.append(
+        ("dnnl.conv2d_bias_sum_relu", make_conv_bias_sum_relu_pattern("nn.conv2d"), make_predicate(add_checker))
+    ),
+    dnnl_patterns.append(
+        ("dnnl.conv2d_bias_sum", make_conv_bias_sum_relu_pattern("nn.conv2d", False), make_predicate(add_checker))
+    ),

Review Comment:
   ```suggestion
       dnnl_patterns.append(
           (
               "dnnl.conv2d_bias_sum_relu",
               make_conv_bias_sum_relu_pattern("nn.conv2d"),
               make_predicate(add_checker),
           )
       )
       dnnl_patterns.append(
           (
               "dnnl.conv2d_bias_sum",
               make_conv_bias_sum_relu_pattern("nn.conv2d", False),
               make_predicate(add_checker),
           )
       )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org