You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2025/09/23 16:49:40 UTC

[PR] MINOR: Correct the docs of inter.worker.signature.algorithm [kafka]

majialoong opened a new pull request, #20576:
URL: https://github.com/apache/kafka/pull/20576

   1. Fix doc of 'inter.worker.signature.algorithm' config in DistributedConfig.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Improve the documentation content for DistributedConfig [kafka]

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #20576:
URL: https://github.com/apache/kafka/pull/20576#discussion_r2373233194


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -206,20 +206,20 @@ public final class DistributedConfig extends WorkerConfig {
     public static final Long INTER_WORKER_KEY_SIZE_DEFAULT = null;
 
     public static final String INTER_WORKER_KEY_TTL_MS_CONFIG = "inter.worker.key.ttl.ms";
-    public static final String INTER_WORKER_KEY_TTL_MS_MS_DOC = "The TTL of generated session keys used for "
+    public static final String INTER_WORKER_KEY_TTL_MS_DOC = "The TTL of generated session keys used for "
         + "internal request validation (in milliseconds)";
-    public static final int INTER_WORKER_KEY_TTL_MS_MS_DEFAULT = Math.toIntExact(TimeUnit.HOURS.toMillis(1));
+    public static final int INTER_WORKER_KEY_TTL_MS_DEFAULT = Math.toIntExact(TimeUnit.HOURS.toMillis(1));
 
     public static final String INTER_WORKER_SIGNATURE_ALGORITHM_CONFIG = "inter.worker.signature.algorithm";
     public static final String INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT = "HmacSHA256";
     public static final String INTER_WORKER_SIGNATURE_ALGORITHM_DOC = "The algorithm used to sign internal requests"
-            + "The algorithm '" + INTER_WORKER_SIGNATURE_ALGORITHM_CONFIG + "' will be used as a default on JVMs that support it; "
+            + "The algorithm '" + INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT + "' will be used as a default on JVMs that support it; "

Review Comment:
   Can you also add a dot (and a space) to end the sentence just before? Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Improve the documentation content for DistributedConfig [kafka]

Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on code in PR #20576:
URL: https://github.com/apache/kafka/pull/20576#discussion_r2373705548


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##########
@@ -206,20 +206,20 @@ public final class DistributedConfig extends WorkerConfig {
     public static final Long INTER_WORKER_KEY_SIZE_DEFAULT = null;
 
     public static final String INTER_WORKER_KEY_TTL_MS_CONFIG = "inter.worker.key.ttl.ms";
-    public static final String INTER_WORKER_KEY_TTL_MS_MS_DOC = "The TTL of generated session keys used for "
+    public static final String INTER_WORKER_KEY_TTL_MS_DOC = "The TTL of generated session keys used for "
         + "internal request validation (in milliseconds)";
-    public static final int INTER_WORKER_KEY_TTL_MS_MS_DEFAULT = Math.toIntExact(TimeUnit.HOURS.toMillis(1));
+    public static final int INTER_WORKER_KEY_TTL_MS_DEFAULT = Math.toIntExact(TimeUnit.HOURS.toMillis(1));
 
     public static final String INTER_WORKER_SIGNATURE_ALGORITHM_CONFIG = "inter.worker.signature.algorithm";
     public static final String INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT = "HmacSHA256";
     public static final String INTER_WORKER_SIGNATURE_ALGORITHM_DOC = "The algorithm used to sign internal requests"
-            + "The algorithm '" + INTER_WORKER_SIGNATURE_ALGORITHM_CONFIG + "' will be used as a default on JVMs that support it; "
+            + "The algorithm '" + INTER_WORKER_SIGNATURE_ALGORITHM_DEFAULT + "' will be used as a default on JVMs that support it; "

Review Comment:
   I forgot to address this issue, thank you for pointing it out. I have now resolved it and updated the latest results in the conversation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Correct the docs of inter.worker.signature.algorithm [kafka]

Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #20576:
URL: https://github.com/apache/kafka/pull/20576#issuecomment-3324858770

   before:
   1. `inter.worker.signature.algorithm` and `inter.worker.verification.algorithms`
    <img width="644" height="654" alt="image" src="https://github.com/user-attachments/assets/86b55600-2397-4383-b00a-6aca54bda1f1" />
   
   2. `worker.unsync.backoff.ms`
   <img width="615" height="230" alt="image" src="https://github.com/user-attachments/assets/4a07ecaf-94e6-4251-8a77-717da17f8694" />
   
   
   after:
   1. `inter.worker.signature.algorithm` and `inter.worker.verification.algorithms`
   <img width="665" height="648" alt="image" src="https://github.com/user-attachments/assets/c64e2a59-fbaf-4f14-b975-0cd92f635349" />
   
   2. `worker.unsync.backoff.ms`
   <img width="629" height="241" alt="image" src="https://github.com/user-attachments/assets/75a17ebb-2500-4c36-8b30-26b1a4de9c98" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Improve the documentation content for DistributedConfig [kafka]

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #20576:
URL: https://github.com/apache/kafka/pull/20576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org