[GitHub] [phoenix] lhofhansl commented on a change in pull request #1161: PHOENIX-6408 LIMIT on local index query with uncovered columns in the WHERE returns wrong result.

[GitBox <gi...@apache.org>]

lhofhansl commented on a change in pull request #1161:
URL: https://github.com/apache/phoenix/pull/1161#discussion_r591719122



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java
##########
@@ -240,6 +245,9 @@ public boolean nextRaw(List<Cell> result) throws IOException {
                     return next;
                 }
             }
+            if (extraLimit >= 0 && --extraLimit == 0) {

Review comment:
       It does not matter as long as this is after the local index extra where filtering. I wanted to isolate that to local indexing only, to not affect the other code paths.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org