You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/12/02 11:47:00 UTC

[GitHub] [ofbiz-framework] bjugl opened a new pull request #379: Fixed: Induction from DB does not represent relations properly.

bjugl opened a new pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379


   Fixed: Induction from DB does not represent relations properly.
   (OFBIZ-12178)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] mbrohl commented on pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984677525


   It's clearly stated, please have a look at the information below the title.
   Both target an source branches are named with reference to the 18.12 branch: "bjugl wants to merge 1 commit into apache:release18.12 from ecomify:OFBIZ-12178_ModelInduce_Relations_18_12"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #379: Fixed: Induction from DB does not represent relations properly.

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984554810


   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; ![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=379&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=379) No Coverage information  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=379&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=379&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] mbrohl edited a comment on pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
mbrohl edited a comment on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984677525


   It's clearly stated, please have a look at the information below the title.
   Both target an source branches are named with reference to the 18.12 branch: "bjugl wants to merge 1 commit into apache:release18.12 from ecomify:OFBIZ-12178_ModelInduce_Relations_18_12"
   
   There already was a commit to trunk, this is the backport PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] mbrohl commented on pull request #379: Fixed: Induction from DB does not represent relations properly.

Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984664103


   > I tried to merge the commits in this PR into a test branch (based on current trunk), and it didn't go through. Multiple rejection files were created.
   
   This PR is targeted towards the 18.12 release branch, it's not for trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #379: Fixed: Induction from DB does not represent relations properly.

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984595557


   Hi @bjugl,
   
    I tried to merge the commits in this PR to a test branch (based on current trunk), and it didn't go through. Multiple rejection files were created.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] mbrohl merged pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
mbrohl merged pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984674645


   > > I tried to merge the commits in this PR into a test branch (based on current trunk), and it didn't go through. Multiple rejection files were created.
   > 
   > This PR is targeted towards the 18.12 release branch, it's not for trunk.
   
   Thanks for the update, @mbrohl 
   The ticket, however, states otherwise. 
   Furthermore, the description (given on Feb 16 of this year) does not indicate that this improvement solely applies to the branch started almost 3 years ago. Of course, it could be the case. But shouldn't that be reflected in the ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] mbrohl commented on pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
mbrohl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984668229


   > Please consider (for next time around) to keep the ticket id on the first line. Otherwise the PR won't be referenced in the ticket.
   
   Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984686682


   Thanks, Michael.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #379: Fixed: Induction from DB does not represent relations properly.

Posted by GitBox <gi...@apache.org>.
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984658188


   HI @bjugl,
   
   Please consider (for next time around) to keep the ticket id on the first line. Otherwise the PR won't be referenced in the ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #379: Fixed: Induction from DB does not represent relations properly.

Posted by GitBox <gi...@apache.org>.
PierreSmits edited a comment on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984595557


   Hi @bjugl,
   
    I tried to merge the commits in this PR into a test branch (based on current trunk), and it didn't go through. Multiple rejection files were created.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] bjugl commented on pull request #379: Fixed: Induction from DB does not represent relations properly (OFBIZ-12178)

Posted by GitBox <gi...@apache.org>.
bjugl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984672315


   Thank you, Michael.
   
   On 02.12.21 15:17, Michael Brohl ***@***.***> wrote:
   >     Please consider (for next time around) to keep the ticket id on the
   >     first line. Otherwise the PR won't be referenced in the ticket.
   > 
   > Fixed.
   > 
   > 
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub 
   > <https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984668229>, 
   > or unsubscribe 
   > <https://github.com/notifications/unsubscribe-auth/AOR2Q4FFJMIBK6RGQ2AXB3TUO55ZLANCNFSM5JG5ABYA>.
   > Triage notifications on the go with GitHub Mobile for iOS 
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> 
   > or Android 
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. 
   > 
   > 
   > 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org