You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/07/29 17:58:14 UTC
Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or
implicit dedication doesn't generate a usage even
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13020/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Kishan Kavala.
Bugs: 3252
Repository: cloudstack-git
Description
-------
If an instance is deployed using explicit or implicit dedication, or neither of them a usage event isn't generated.
Added 2 new usage_events :
EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT
generated when VMs are deployed using corresponding dedications.
Diffs
-----
api/src/com/cloud/event/EventTypes.java 6f1eed6
server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e
Diff: https://reviews.apache.org/r/13020/diff/
Testing
-------
usage_events table has now entries for new types:
select * from usage_event where type like "VM%CREATE%"
id: 25
type: VM.CREATE.IMPLICIT
account_id: 2
created: 2013-07-29 15:46:36
zone_id: 1
resource_id: 7
resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54
offering_id: 15
template_id: 5
size: NULL
resource_type: XenServer
processed: 0
virtual_size: NULL
Build passed.
Patch applies cleanly.
Thanks,
Saksham Srivastava
Re: Review Request 13020: CLOUDSTACK-3252 An instance deployed using
explicit or implicit dedication doesn't generate a usage even
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13020/#review24152
-----------------------------------------------------------
Review 13020 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #74 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/74/
- Jenkins Cloudstack.org
On July 29, 2013, 3:58 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13020/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 3:58 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Kishan Kavala.
>
>
> Bugs: 3252
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> If an instance is deployed using explicit or implicit dedication, or neither of them a usage event isn't generated.
> Added 2 new usage_events :
> EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT
> generated when VMs are deployed using corresponding dedications.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java 6f1eed6
> server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e
>
> Diff: https://reviews.apache.org/r/13020/diff/
>
>
> Testing
> -------
>
> usage_events table has now entries for new types:
> select * from usage_event where type like "VM%CREATE%"
> id: 25
> type: VM.CREATE.IMPLICIT
> account_id: 2
> created: 2013-07-29 15:46:36
> zone_id: 1
> resource_id: 7
> resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54
> offering_id: 15
> template_id: 5
> size: NULL
> resource_type: XenServer
> processed: 0
> virtual_size: NULL
>
>
> Build passed.
> Patch applies cleanly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: Review Request 13020: CLOUDSTACK-3252 An instance deployed using
explicit or implicit dedication doesn't generate a usage even
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13020/#review24232
-----------------------------------------------------------
COde changes are required in UsageManager to handle new usage event
- Kishan Kavala
On July 29, 2013, 9:28 p.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13020/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 9:28 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Kishan Kavala.
>
>
> Bugs: 3252
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> If an instance is deployed using explicit or implicit dedication, or neither of them a usage event isn't generated.
> Added 2 new usage_events :
> EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT
> generated when VMs are deployed using corresponding dedications.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java 6f1eed6
> server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e
>
> Diff: https://reviews.apache.org/r/13020/diff/
>
>
> Testing
> -------
>
> usage_events table has now entries for new types:
> select * from usage_event where type like "VM%CREATE%"
> id: 25
> type: VM.CREATE.IMPLICIT
> account_id: 2
> created: 2013-07-29 15:46:36
> zone_id: 1
> resource_id: 7
> resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54
> offering_id: 15
> template_id: 5
> size: NULL
> resource_type: XenServer
> processed: 0
> virtual_size: NULL
>
>
> Build passed.
> Patch applies cleanly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>