You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2026/07/14 10:22:33 UTC

(superset) 02/02: fix(a11y): use more specific label text for tag description field

This is an automated email from the ASF dual-hosted git repository.

eschutho pushed a commit to branch fix/a11y-tagmodal-description-label
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 3d60765b15e9615efd5a8c6017d4dd078894c606
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Tue Jul 14 10:18:22 2026 +0000

    fix(a11y): use more specific label text for tag description field
    
    Self-review suggested "Tag description" for parity with the sibling
    "Tag name" field, since a generic "Description" label is more
    ambiguous outside the dialog's visual context (e.g. in a flattened
    screen-reader forms list).
---
 superset-frontend/src/features/tags/TagModal.test.tsx | 2 +-
 superset-frontend/src/features/tags/TagModal.tsx      | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/features/tags/TagModal.test.tsx b/superset-frontend/src/features/tags/TagModal.test.tsx
index c9235e001e9..ee38ff43ecb 100644
--- a/superset-frontend/src/features/tags/TagModal.test.tsx
+++ b/superset-frontend/src/features/tags/TagModal.test.tsx
@@ -47,7 +47,7 @@ test('renders correctly in create mode', () => {
 
 test('description input has an accessible name', async () => {
   render(<TagModal {...mockedProps} />);
-  expect(await screen.findByLabelText('Description')).toBeInTheDocument();
+  expect(await screen.findByLabelText('Tag description')).toBeInTheDocument();
 });
 
 test('renders correctly in edit mode', () => {
diff --git a/superset-frontend/src/features/tags/TagModal.tsx b/superset-frontend/src/features/tags/TagModal.tsx
index bdb1bfca8f6..1d80276d453 100644
--- a/superset-frontend/src/features/tags/TagModal.tsx
+++ b/superset-frontend/src/features/tags/TagModal.tsx
@@ -312,7 +312,9 @@ const TagModal: FC<TagModalProps> = ({
         </Flex>
 
         <Flex vertical gap={theme.sizeUnit}>
-          <FormLabel htmlFor="tag-description">{t('Description')}</FormLabel>
+          <FormLabel htmlFor="tag-description">
+            {t('Tag description')}
+          </FormLabel>
           <Input
             id="tag-description"
             className="tag-input"