You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2023/04/30 12:41:42 UTC
[doris] 15/18: [fix](planner) ctas should not clone queryStmt after parse (#19114)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
commit f84d67f914dc3830f24eba5816076e5ea45c045e
Author: AKIRA <33...@users.noreply.github.com>
AuthorDate: Thu Apr 27 21:09:11 2023 +0900
[fix](planner) ctas should not clone queryStmt after parse (#19114)
Remove redundant clone in the constructor of CTAS stmt
Error message:
```
NullPointerException, msg: java.lang.NullPointerException: null
```
---
.../main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java | 2 +-
.../src/main/java/org/apache/doris/analysis/FunctionCallExpr.java | 5 -----
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java
index 284b861716..45bdb4bdbb 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java
@@ -51,7 +51,7 @@ public class CreateTableAsSelectStmt extends DdlStmt {
this.createTableStmt = createTableStmt;
this.columnNames = columnNames;
this.queryStmt = queryStmt;
- this.insertStmt = new InsertStmt(createTableStmt.getDbTbl(), queryStmt.clone());
+ this.insertStmt = new InsertStmt(createTableStmt.getDbTbl(), queryStmt);
}
/**
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
index c24777ae60..2500e67b7e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
@@ -1455,11 +1455,6 @@ public class FunctionCallExpr extends Expr {
}
// rewrite return type if is nested type function
analyzeNestedFunction();
- for (OrderByElement o : orderByElements) {
- if (!o.getExpr().isAnalyzed) {
- o.getExpr().analyzeImpl(analyzer);
- }
- }
}
// if return type is nested type, need to be determined the sub-element type
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org