You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/04/23 21:00:53 UTC

[jira] Resolved: (POOL-166) GenericKeyedObjectPool.destroy could use entrySet() rather than keySet() followed by get()

     [ https://issues.apache.org/jira/browse/POOL-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved POOL-166.
-----------------------

    Fix Version/s: 1.5.5
       Resolution: Fixed

Fixed with slightly amended patch (key variable assigned outside inner loop)

> GenericKeyedObjectPool.destroy could use entrySet() rather than keySet() followed by get()
> ------------------------------------------------------------------------------------------
>
>                 Key: POOL-166
>                 URL: https://issues.apache.org/jira/browse/POOL-166
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.5.5
>
>         Attachments: GenericKeyedObjectPool.patch
>
>
> [Findbugs]
> It would be more efficient if GenericKeyedObjectPool.destroy used entrySet() rather than keySet() followed by get()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.