You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/18 03:48:53 UTC

[GitHub] [rocketmq-exporter] MatrixHB opened a new pull request, #125: [RIP-46] enable exporter to collect and export open-telemetry metrics

MatrixHB opened a new pull request, #125:
URL: https://github.com/apache/rocketmq-exporter/pull/125

   This is part of implementation of [RIP-46](https://github.com/apache/rocketmq/wiki/RIP-46-Observability-improvement-for-RocketMQ)
   
   Since [#5355](https://github.com/apache/rocketmq/pull/5355), a new version of broker metrics based on open-telemetry standard has been introduced into rocketmq broker. Different form the previous version, the new metrics are produced by broker, proxy or client, not by exporter.
   
   Some users are now using rocketmq-exporter. New metrics require compatibility with current usage. And the control panel, such as Prometheus, is not necessarily deployed under the same network as broker. So It is also meaningful to design a proxy mode of rocketmq-exporter to access new metrics data.
   
   We could implement an OpenTelemetry collector in rocketmq-exporter: Broker export metrics data to rocketmq-exporter, and rocketmq-exporter provide a new endpoint for Prometheus access.
   
   ![image](https://user-images.githubusercontent.com/23614576/213078853-ed5372e5-2b63-4c0f-b4e1-2202ce61447f.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [RIP-46] enable exporter to collect and export open-telemetry metrics [rocketmq-exporter]

Posted by "francisoliverlee (via GitHub)" <gi...@apache.org>.
francisoliverlee commented on PR #125:
URL: https://github.com/apache/rocketmq-exporter/pull/125#issuecomment-1953430323

   it's great to see this, can you update confilct files and resend pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [RIP-46] enable exporter to collect and export open-telemetry metrics [rocketmq-exporter]

Posted by "francisoliverlee (via GitHub)" <gi...@apache.org>.
francisoliverlee merged PR #125:
URL: https://github.com/apache/rocketmq-exporter/pull/125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-exporter] ShadowySpirits commented on a diff in pull request #125: [RIP-46] enable exporter to collect and export open-telemetry metrics

Posted by "ShadowySpirits (via GitHub)" <gi...@apache.org>.
ShadowySpirits commented on code in PR #125:
URL: https://github.com/apache/rocketmq-exporter/pull/125#discussion_r1092831005


##########
pom.xml:
##########
@@ -10,21 +10,22 @@
     </parent>
     <groupId>org.apache</groupId>
     <artifactId>rocketmq-exporter</artifactId>
-    <version>0.0.2-SNAPSHOT</version>
+    <version>0.0.3-SNAPSHOT</version>
     <name>rocketmq-exporter</name>
 
     <description>Apache RocketMQ Prometheus Exporter</description>
 
     <properties>
         <rocketmq.version>4.9.4</rocketmq.version>
         <docker.image.prefix>docker.io</docker.image.prefix>
+        <opentelemetry-proto.version>0.18.0-alpha</opentelemetry-proto.version>

Review Comment:
   It's better to update to 1.19.0 to keep the same as RocketMQ.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-exporter] aaron-ai commented on a diff in pull request #125: [RIP-46] enable exporter to collect and export open-telemetry metrics

Posted by "aaron-ai (via GitHub)" <gi...@apache.org>.
aaron-ai commented on code in PR #125:
URL: https://github.com/apache/rocketmq-exporter/pull/125#discussion_r1092869046


##########
pom.xml:
##########
@@ -53,7 +54,22 @@
         <dependency>
             <groupId>io.prometheus</groupId>
             <artifactId>simpleclient</artifactId>
-            <version>0.6.0</version>
+            <version>0.15.0</version>

Review Comment:
   declare version in properties, just like `rocketmq.version`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org