[GitHub] [pulsar] hangc0276 commented on a diff in pull request #21095: [fix][broker] Use expireAfterAccess instead of expireAfterWrite for metadata cache

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 commented on code in PR #21095:
URL: https://github.com/apache/pulsar/pull/21095#discussion_r1311758321


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCacheConfig.java:
##########
@@ -46,5 +46,12 @@ public class MetadataCacheConfig {
      * A negative or zero value disables automatic expiration.
      */
     @Builder.Default
-    private final long expireAfterWriteMillis = 2 * DEFAULT_CACHE_REFRESH_TIME_MILLIS;
+    private final long expireAfterWriteMillis = 0L;

Review Comment:
   Change the default value to `-1`. Use -1 to disable the expire maybe better to understand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org