You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "kennknowles (via GitHub)" <gi...@apache.org> on 2023/09/25 21:24:42 UTC

[GitHub] [beam] kennknowles opened a new pull request, #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

kennknowles opened a new pull request, #28656:
URL: https://github.com/apache/beam/pull/28656

   Quite a lot of manual digging through transitive deps to figure out some of these :-(
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [x] Update `CHANGES.md` with noteworthy changes.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735568637

   GCP test looks worrying, for now at least: https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/3770/testReport/junit/org.apache.beam.sdk.io.gcp.spanner.changestreams/SpannerChangeStreamErrorTest/testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings/
   
   SpannerChangeStreamErrorTest.testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings
   
   ```
   org.junit.runners.model.TestTimedOutException: test timed out after 600 seconds
   	at sun.misc.Unsafe.park(Native Method)
   	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
   	at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
   	at java.util.concurrent.LinkedBlockingQueue.poll(LinkedBlockingQueue.java:467)
   	at com.google.cloud.spanner.AbstractResultSet$GrpcStreamIterator.computeNext(AbstractResultSet.java:1010)
   	at com.google.cloud.spanner.AbstractResultSet$GrpcStreamIterator.computeNext(AbstractResultSet.java:940)
   	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145)
   	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140)
   	at com.google.cloud.spanner.AbstractResultSet$ResumableStreamIterator.computeNext(AbstractResultSet.java:1249)
   	at com.google.cloud.spanner.AbstractResultSet$ResumableStreamIterator.computeNext(AbstractResultSet.java:1085)
   	at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145)
   	at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140)
   	at com.google.cloud.spanner.AbstractResultSet$GrpcValueIterator.ensureReady(AbstractResultSet.java:289)
   	at com.google.cloud.spanner.AbstractResultSet$GrpcValueIterator.getMetadata(AbstractResultSet.java:265)
   	at com.google.cloud.spanner.AbstractResultSet$GrpcResultSet.next(AbstractResultSet.java:133)
   	at com.google.cloud.spanner.SessionPool$PooledSession.determineDialect(SessionPool.java:1602)
   	at com.google.cloud.spanner.SessionPool$PooledSession.access$5200(SessionPool.java:1370)
   	at com.google.cloud.spanner.SessionPool.getDialect(SessionPool.java:2167)
   	at com.google.cloud.spanner.DatabaseClientImpl.getDialect(DatabaseClientImpl.java:59)
   	at org.apache.beam.sdk.io.gcp.spanner.SpannerIO.getDialect(SpannerIO.java:1710)
   	at org.apache.beam.sdk.io.gcp.spanner.SpannerIO.access$400(SpannerIO.java:375)
   	at org.apache.beam.sdk.io.gcp.spanner.SpannerIO$ReadChangeStream.expand(SpannerIO.java:1623)
   	at org.apache.beam.sdk.io.gcp.spanner.SpannerIO$ReadChangeStream.expand(SpannerIO.java:1416)
   	at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:545)
   	at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:479)
   	at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44)
   	at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:175)
   	at org.apache.beam.sdk.io.gcp.spanner.changestreams.SpannerChangeStreamErrorTest.testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings(SpannerChangeStreamErrorTest.java:234)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735839079

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1734647127

   run java precommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735563286

   On the Hadoop tests, gradle cache flake:
   
   ```
   08:35:50 > Failed to load cache entry 10c9f03b28665c35a0f17f4ed29f54e2 for task ':sdks:java:io:hadoop-format:compileTestJava': Could not load from local cache: Timeout waiting to lock Build cache (/home/jenkins/.gradle/caches/build-cache-1). It is currently in use by another Gradle instance.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735838749

   Same error. Suspect it is real :-(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735867545

   cc @manitgupta and @nancyxu123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1762855903

   Reminder, please take a look at this pr: @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735578241

   ```
           json_org                                    : "org.json:json:20220320", // Keep in sync with everit-json-schema / google_cloud_platform_libraries_bom transitive deps.
   ```
   
   `everit-json-schema` and `google_cloud_platform_libraries_bom` disagree here.
   
   The current version 20220320 is in range for [CVE-2022-45688](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-45688), but likely something that we can handle outside the release scope.
   
   libraries-bom transitively depends on 20230618
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1751364442

   Run Java_Examples_Dataflow PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1737460708

   I was pointed to @darshan-sj -- Darshan, can you please take a look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #28656:
URL: https://github.com/apache/beam/pull/28656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1764962664

   Ah, noting the "4 pending checks" that are actually green on Jenkins:
   
   https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java17_Commit/8916/
   https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/3891/
   https://ci-beam.apache.org/job/beam_PreCommit_Java_PVR_Flink_Batch_Commit/3448/
   https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Commit/17501/
   
   And the Python coverage is not relevant (but should probably not fail on this, so that's a bug but it is too long and flaky to kick a bunch of times here)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1741014354

   I have logged in to Jenkins and ensured that this build will not be garbage collected: https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Phrase/238/
   
   The failure is [SpannerChangeStreamErrorTest.testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Phrase/238/testReport/junit/org.apache.beam.sdk.io.gcp.spanner.changestreams/SpannerChangeStreamErrorTest/testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings/)
   
   It times out after 10 minutes. The log in its entirety appears to be:
   
   ```
   Sep 26, 2023 4:17:33 PM org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor getOrCreate
   INFO: Connecting to SpannerConfig{projectId=my-project, instanceId=my-instance, databaseId=my-database, host=https://batch-spanner.googleapis.com/, emulatorHost=my-host, isLocalChannelProvider=true, commitDeadline=PT15S, maxCumulativeBackoff=PT900S, executeStreamingSqlRetrySettings=RetrySettings{totalTimeout=PT5M, initialRetryDelay=PT0S, retryDelayMultiplier=1.0, maxRetryDelay=PT0S, maxAttempts=0, jittered=true, initialRpcTimeout=PT1M, rpcTimeoutMultiplier=1.0, maxRpcTimeout=PT1M}, commitRetrySettings=null, retryableCodes=[UNAVAILABLE, ABORTED], rpcPriority=MEDIUM, databaseRole=null, partitionQueryTimeout=null, partitionReadTimeout=null, serviceFactory=null, dataBoostEnabled=null}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1741229940

   I think the problem is with the Beam test. It is testing bug-for-bug compatibility of the `getDialect` call and perhaps the bug was, in fact, fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1751275174

   Run Java_IOs_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1763523677

   Run Python_Coverage PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735479420

   (cd release/src/main/scripts && ./verify_release_build.sh)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735562520

   Run Java_hadoop_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bvolpato commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735865738

   ```
   09:59:25 org.apache.beam.sdk.io.gcp.spanner.changestreams.SpannerChangeStreamErrorTest > testAbortedExceptionNotRetriedithDefaultsForStreamSqlRetrySettings FAILED
   09:59:25     java.lang.AssertionError at MatcherAssert.java:18
   ```
   
   Judging by the test, not hard to imagine that we'd have failures if they changed the defaults.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1737481363

   If it is just the test, then I'm OK with a cherrypick. Otherwise I think we have to skip this BOM version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1741227240

   Now that I have had a minute to look at it rather than just copy/pasting the error, summarizing the stack trace and what it means: it seems to be hanging in `getDialect` which happens client-side as part of building the graph, not during pipeline execution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1741231334

   No that is not the case. The test is expecting the request to time out but instead the test times out while the request is still active (possibly during a retry).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "bvolpato (via GitHub)" <gi...@apache.org>.
bvolpato commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1763523526

   Run Java PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0 [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1764878058

   run java precommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] github-actions[bot] commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1734555480

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @damccorm for label build.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] codecov[bot] commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1734528957

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28656?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#28656](https://app.codecov.io/gh/apache/beam/pull/28656?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8ba2e3e) into [master](https://app.codecov.io/gh/apache/beam/commit/de6cc236907776a36bbe46672bda0c2cbbaebb2d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (de6cc23) will **increase** coverage by `0.02%`.
   > Report is 8 commits behind head on master.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #28656      +/-   ##
   ==========================================
   + Coverage   72.21%   72.23%   +0.02%     
   ==========================================
     Files         684      684              
     Lines      101127   101141      +14     
   ==========================================
   + Hits        73032    73064      +32     
   + Misses      26517    26499      -18     
     Partials     1578     1578              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/28656/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/28656/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.79% <ø> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 14 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28656/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] kennknowles commented on pull request #28656: Update Google Cloud Java Libraries BOM from 26.22.0 to 26.23.0

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #28656:
URL: https://github.com/apache/beam/pull/28656#issuecomment-1735569693

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org