[GitHub] [spark] squito commented on a change in pull request #24374: [SPARK-27366][CORE] Support GPU Resources in Spark job scheduling

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #24374: [SPARK-27366][CORE] Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275605921
 
 

 ##########
 File path: examples/src/main/resources/getGpuResources.sh
 ##########
 @@ -0,0 +1,2 @@
++# This script uses nvidia-smi command so only works with nvidia GPUs. This is a very basic script that lists the index's of the available GPU's where the executor was allocated.
 
 Review comment:
   do cluster managers do something special so that with multiple executors, a script like this finds the right subset of gpus?  I assume standalone does not, but maybe others do?  That is worth mentioning somewhere as well (its also fine if that part of the story is in a later jira).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org