[jira] Updated: (JCR-1162) Improve logging in NodeTypeRegistry.persistCustomNodeTypeDefs

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCR-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1162:
-------------------------------

      Component/s: nodetype
                   jackrabbit-core
         Priority: Minor  (was: Major)
    Fix Version/s: 1.4
         Assignee: Jukka Zitting

I believe this is an example of a more widespread problem within Jackrabbit. IMHO we should generally treat exceptions from close() just as we would exceptions from read() or write().

> Improve logging in NodeTypeRegistry.persistCustomNodeTypeDefs
> -------------------------------------------------------------
>
>                 Key: JCR-1162
>                 URL: https://issues.apache.org/jira/browse/JCR-1162
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, nodetype
>            Reporter: Martijn Hendriks
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.4
>
>
> When the closing of out in the finally block of persistCustomNodeTypeDefs throws an IOException this is ignored. At least some logging should take place, because an IOException here might still mean that the custom nodetype definitions were not stored correctly. This is the case, for instance, when a DatabaseFileSystem is used: the call to out.close triggers the SQL statement execution which causes an IOException if it fails. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.