You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2023/02/04 15:08:26 UTC
Change in asterixdb[stabilization-667a908755]: [ASTERIXDB-3101][COMP] Make sure PushFieldAccessRule returns true whe...
From Ali Alsuliman <al...@gmail.com>:
Attention is currently required from: Murtadha Hubail, Till Westmann, Michael Blow.
Hello Murtadha Hubail, Till Westmann, Jenkins, Michael Blow, Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17361
to look at the new patch set (#2).
Change subject: [ASTERIXDB-3101][COMP] Make sure PushFieldAccessRule returns true when fired
......................................................................
[ASTERIXDB-3101][COMP] Make sure PushFieldAccessRule returns true when fired
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
If an assign operator has been moved next to the data
scan operator, return true since the plan has been changed.
Also, make sure to add all the skipped intermediate assigns
to the already compared set.
Change-Id: Ic7e622aa36373a11f10f95ab5d045d51a2c0479e
---
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/rtree-index-join/leftouterjoin-probe-pidx-with-join-rtree-sidx_01_ps.plan
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-open-index/rtree-index-join/leftouterjoin-probe-pidx-with-join-rtree-sidx_01_ps.plan
3 files changed, 120 insertions(+), 87 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/61/17361/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17361
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-667a908755
Gerrit-Change-Id: Ic7e622aa36373a11f10f95ab5d045d51a2c0479e
Gerrit-Change-Number: 17361
Gerrit-PatchSet: 2
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Attention: Murtadha Hubail <mh...@apache.org>
Gerrit-Attention: Till Westmann <ti...@apache.org>
Gerrit-Attention: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newpatchset