[GitHub] [airflow] Taragolis commented on a diff in pull request #29569: Avoid importing executor during conf validation

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #29569:
URL: https://github.com/apache/airflow/pull/29569#discussion_r1111060163


##########
tests/www/views/test_views_tasks.py:
##########
@@ -492,7 +496,7 @@ def test_code_from_db_all_example_dags(admin_client):
                 dag_id="example_bash_operator",
                 ignore_all_deps="false",
                 ignore_ti_state="true",
-                execution_date=DEFAULT_DATE,
+                dag_run_id=DEFAULT_DAGRUN,

Review Comment:
   I guess we use mock client rather than actually call views here: https://flask.palletsprojects.com/en/2.2.x/testing/#sending-requests-with-the-test-client
   
   https://github.com/apache/airflow/blob/f17e2ba48b59525655a92e04684db664a672918f/tests/www/views/conftest.py#L64-L65



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org