You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "roseduan (via GitHub)" <gi...@apache.org> on 2025/06/06 08:24:52 UTC
[PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
roseduan opened a new pull request, #1147:
URL: https://github.com/apache/cloudberry/pull/1147
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#discussion_r2193576882
##########
contrib/cloudberry_fdw/Makefile:
##########
@@ -0,0 +1,58 @@
+# contrib/cloudberry_fdw/Makefile
+
+MODULE_big = cloudberry_fdw
+OBJS_FRONTEND = \
+ link-canary.o
+
+OBJS = \
+ $(WIN32RES) \
+ $(OBJS_FRONTEND) \
+ connection.o \
+ deparse.o \
+ option.o \
+ cloudberry_fdw.o \
+ shippable.o
+
+PGFILEDESC = "cloudberry_fdw - foreign data wrapper for Cloudberry"
+
+PG_CPPFLAGS = -I$(libpq_srcdir)
+SHLIB_LINK_INTERNAL = -Wl,-Bsymbolic -Wl,-Bstatic -Wl,-Bstatic $(libpq) -Wl,-Bdynamic
Review Comment:
refer to `(https://github.com/apache/cloudberry/commit/667f0c37bc6d7bce7be8b758652ef95ddb823e19)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it commented on PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#issuecomment-2948821051
The code looks like it was copied from postgres_fdw. Please explain the reasons and considerations behind the work. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#discussion_r2133018404
##########
contrib/cloudberry_fdw/cloudberry_fdw.h:
##########
@@ -0,0 +1,269 @@
+/*-------------------------------------------------------------------------
+ *
+ * postgres_fdw.h
+ * Foreign-data wrapper for remote PostgreSQL servers
+ *
+ * Portions Copyright (c) 2012-2021, PostgreSQL Global Development Group
+ *
+ * IDENTIFICATION
+ * contrib/postgres_fdw/postgres_fdw.h
Review Comment:
-> contrib/cloudberry_fdw/cloudberry_fdw.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "avamingli (via GitHub)" <gi...@apache.org>.
avamingli commented on PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#issuecomment-2954542478
> The code looks like it was copied from postgres_fdw. Please explain the reasons and considerations behind the work. Thanks
+1,
We need to keep the PostgreSQL code unchanged to preserve their commit history, contributions, and intellectual property. Directly copying it would lead to significant issues in future kernel upgrades. Even without these reasons, the code in postgres_fdw has been developed collaboratively by many individuals over the years, and we should respect their work and not take credit for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it closed pull request #1147: Introduce cloudberry_fdw to run queries between one and more CBDB clusters
URL: https://github.com/apache/cloudberry/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#discussion_r2193575184
##########
contrib/cloudberry_fdw/Makefile:
##########
@@ -0,0 +1,58 @@
+# contrib/cloudberry_fdw/Makefile
+
+MODULE_big = cloudberry_fdw
+OBJS_FRONTEND = \
+ link-canary.o
+
+OBJS = \
+ $(WIN32RES) \
+ $(OBJS_FRONTEND) \
+ connection.o \
+ deparse.o \
+ option.o \
+ cloudberry_fdw.o \
+ shippable.o
+
+PGFILEDESC = "cloudberry_fdw - foreign data wrapper for Cloudberry"
+
+PG_CPPFLAGS = -I$(libpq_srcdir)
+SHLIB_LINK_INTERNAL = -Wl,-Bsymbolic -Wl,-Bstatic -Wl,-Bstatic $(libpq) -Wl,-Bdynamic
Review Comment:
why double `-Bstatic` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#discussion_r2133012426
##########
contrib/cloudberry_fdw/cloudberry_fdw.h:
##########
@@ -0,0 +1,269 @@
+/*-------------------------------------------------------------------------
+ *
+ * postgres_fdw.h
+ * Foreign-data wrapper for remote PostgreSQL servers
+ *
+ * Portions Copyright (c) 2012-2021, PostgreSQL Global Development Group
Review Comment:
Apache Licence ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Introduce cloudberry_fdw to run queries between one and more CBDB clusters [cloudberry]
Posted by "avamingli (via GitHub)" <gi...@apache.org>.
avamingli commented on PR #1147:
URL: https://github.com/apache/cloudberry/pull/1147#issuecomment-2954547683
Do we have CI test for this fdw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org