You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/03 09:49:53 UTC

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #254: Fix emoji decoding error

wongoo commented on pull request #254:
URL: https://github.com/apache/dubbo-go-hessian2/pull/254#issuecomment-753592268


   ## benchmark result
   
   before fixing:
   ```
   BenchmarkDecodeStringAscii
   BenchmarkDecodeStringAscii-8                6952            173795 ns/op
   BenchmarkDecodeStringUnicode
   BenchmarkDecodeStringUnicode-8              5228            229713 ns/op
   BenchmarkDecodeStringEmoji
       string_test.go:230: err: bad utf-8 encoding
   --- FAIL: BenchmarkDecodeStringEmoji
   ```
   
   after fixing:
   ```
   BenchmarkDecodeStringAscii
   BenchmarkDecodeStringAscii-8                7149            145317 ns/op
   BenchmarkDecodeStringUnicode
   BenchmarkDecodeStringUnicode-8              5768            182145 ns/op
   BenchmarkDecodeStringEmoji
   BenchmarkDecodeStringEmoji-8                1400            816080 ns/op
   ```
   
   with 17% performance improvement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org