You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 00:40:21 UTC

[GitHub] [incubator-superset] mistercrunch commented on pull request #11182: chore: limiting load-examples to demo-worthy dashboards by default

mistercrunch commented on pull request #11182:
URL: https://github.com/apache/incubator-superset/pull/11182#issuecomment-714072006


   THIS IS DRIVING ME CRAZY. From my understanding our `cypress` tests use hard-coded ids which assume a certain ordering in how datasets are created. 
   
   ```
   $ git grep "__table" superset-frontend/cypress-base/
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/area.test.js:    datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/big_number.test.js:    datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/box_plot.test.js:    datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/bubble.test.js:    datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/compare.test.js:    datasource: '3__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/dual_line.test.js:    datasource: '3__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/histogram.test.js:    datasource: '3__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/pie.test.js:    datasource: '3__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/pivot_table.test.js:    datasource: '3__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/sankey.test.js:    datasource: '1__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/shared.helper.js:  datasource: '3__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/shared.helper.js:  datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/sunburst.test.js:    datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/treemap.test.js:    datasource: '2__table',
   superset-frontend/cypress-base/cypress/integration/explore/visualizations/world_map.test.js:    datasource: '2__table',
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org