[jira] Closed: (CONTINUUM-651) DefaultContinuumScm.getScmRepository should not set project scm username/password if they are the empty string

["Emmanuel Venisse (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/CONTINUUM-651?page=all ]
     
Emmanuel Venisse closed CONTINUUM-651:
--------------------------------------

     Assign To: Emmanuel Venisse
    Resolution: Won't Fix

It's already what we have

> DefaultContinuumScm.getScmRepository should not set project scm username/password if they are the empty string
> --------------------------------------------------------------------------------------------------------------
>
>          Key: CONTINUUM-651
>          URL: http://jira.codehaus.org/browse/CONTINUUM-651
>      Project: Continuum
>         Type: Bug

>   Components: Core system
>     Reporter: John Didion
>     Assignee: Emmanuel Venisse

>
>
> Should be using StringUtils.isEmpty instead of doing a null check.
> {noformat}
> if ( !StringUtils.isEmpty(project.getScmUsername()) )
> {
>     providerRepository.setUser( project.getScmUsername() );
>     if ( project.getScmPassword() != null )
>     {
>         providerRepository.setPassword( project.getScmPassword() );
>     }
>     else
>     {
>         providerRepository.setPassword( "" );
>     }
> }
> {noformat}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira