You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/10 11:48:59 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #13103: [FLINK-18752][yarn] Allow shipping single files for yarn execution

tillrohrmann commented on a change in pull request #13103:
URL: https://github.com/apache/flink/pull/13103#discussion_r467794116



##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -282,11 +282,11 @@ private void encodeDirsToShipToCluster(final Configuration configuration, final
 					YarnConfigOptions.SHIP_DIRECTORIES,

Review comment:
       The same applies to the method's name: Maybe `encodeDirsToShipToCluster` -> `encodeFilesToShipToCluster`

##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -282,11 +282,11 @@ private void encodeDirsToShipToCluster(final Configuration configuration, final
 					YarnConfigOptions.SHIP_DIRECTORIES,
 					cmd.getOptionValues(this.shipPath.getOpt()),

Review comment:
       I think we should also update the description of the `shipPath` option.

##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
##########
@@ -282,11 +282,11 @@ private void encodeDirsToShipToCluster(final Configuration configuration, final
 					YarnConfigOptions.SHIP_DIRECTORIES,

Review comment:
       Should we rename this config option since we are now also support shipping files?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org