You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/03 08:23:22 UTC

[GitHub] [airflow] chronitis opened a new pull request #5230: [AIRFLOW-1501] Add GoogleCloudStorageDeleteOperator

chronitis opened a new pull request #5230: [AIRFLOW-1501] Add GoogleCloudStorageDeleteOperator
URL: https://github.com/apache/airflow/pull/5230
 
 
   ### Jira
   
   - [x] My PR addresses https://issues.apache.org/jira/browse/AIRFLOW-1501
   
   This has been previously marked as `Fixed` (a year ago), but no operator appears to either exist in `master` or in any current PR (although delete is supported by the GCS hook).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Creates `GoogleCloudStorageDeleteOperator`, which (analogously to the existing S3 object delete operator), exposes the `delete` function of the GCS hook as an operator supporting templating and deletion either by a list of objects or all objects matching a prefix.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   `tests/contrib/operators/test_gcs_delete_operator.py`
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services