You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2019/11/27 20:05:39 UTC

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table 

Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14806


Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................

IMPALA-9122 : Ignore FileNotFoundException when loading a table

It is possible that when the file metadata of a table or partition is being loaded, some
temporary files (like the ones in .hive-staging directory) are deleted by external
engines like Hive. This causes a FileNotFoundException during the load and it fails the
reload command. In general, this should not be a problem since users are careful not to
modify the table from Hive or Spark while Impala is reading them. In the worst case,
currently the refresh command fails which can be retried by the user. However, the
this does not go well with when event processing is turned on. EventProcessor tries to
reload the table as soon as it sees a INSERT_EVENT from metastore. Hive may be still
cleaning up the staging directories when EventProcessor issues a reload causing it go in
error state.

Ideally, we should have some sort of intra-engine synchronization semantics to avoid such
issues, but that is much more complex architectural change. For now, we should ignore such
errors and skip the deleted file from being loaded.

Testing: [Pending] Unfortunately, this error is hard to reproduce locally. I tried
creating multiple threads which delete some files while multiple FileMetadataLoaders are
loading concurrently but it didn't fail for me so far. Will try running the
TestEventProcessing.test_insert_events multiple times to confirm if I see any failure.

Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
1 file changed, 16 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/14806/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................

IMPALA-9122 : Ignore FileNotFoundException when loading a table

It is possible that when the file metadata of a table or partition is
being loaded, some temporary files (like the ones in .hive-staging
directory) are deleted by external engines like Hive. This causes a
FileNotFoundException during the load and it fails the reload command.
In general, this should not be a problem since users are careful not to
modify the table from Hive or Spark while Impala is reading them. In
the worst case, currently the refresh command fails which can be
retried by the user. However, this does not go well with when event
processing is turned on. EventProcessor tries to reload the table as
soon as it sees a INSERT_EVENT from metastore. Hive may be still
cleaning up the staging directories when EventProcessor issues a reload
causing it go in error state.

Ideally, we should have some sort of intra-engine synchronization
semantics to avoid such issues, but that is much more complex
architectural change. For now, we should ignore such errors and skip
the deleted file from being loaded.

Testing: Unfortunately, this error is hard to reproduce locally. I
tried creating multiple threads which delete some files while multiple
FileMetadataLoaders are loading concurrently but it didn't fail for me.
Ran TestEventProcessing.test_insert_events in a loop for more than an
hour and didn't see any failure.

Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Reviewed-on: http://gerrit.cloudera.org:8080/14806
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 17 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5187/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 01:01:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................

IMPALA-9122 : Ignore FileNotFoundException when loading a table

It is possible that when the file metadata of a table or partition is
being loaded, some temporary files (like the ones in .hive-staging
directory) are deleted by external engines like Hive. This causes a
FileNotFoundException during the load and it fails the reload command.
In general, this should not be a problem since users are careful not to
modify the table from Hive or Spark while Impala is reading them. In
the worst case, currently the refresh command fails which can be
retried by the user. However, this does not go well with when event
processing is turned on. EventProcessor tries to reload the table as
soon as it sees a INSERT_EVENT from metastore. Hive may be still
cleaning up the staging directories when EventProcessor issues a reload
causing it go in error state.

Ideally, we should have some sort of intra-engine synchronization
semantics to avoid such issues, but that is much more complex
architectural change. For now, we should ignore such errors and skip
the deleted file from being loaded.

Testing: Unfortunately, this error is hard to reproduce locally. I
tried creating multiple threads which delete some files while multiple
FileMetadataLoaders are loading concurrently but it didn't fail for me.
Ran TestEventProcessing.test_insert_events in a loop for more than an
hour and didn't see any failure.

Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 17 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/14806/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 18:19:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5332/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 18:19:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 22:46:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................

IMPALA-9122 : Ignore FileNotFoundException when loading a table

It is possible that when the file metadata of a table or partition is
being loaded, some temporary files (like the ones in .hive-staging
directory) are deleted by external engines like Hive. This causes a
FileNotFoundException during the load and it fails the reload command.
In general, this should not be a problem since users are careful not to
modify the table from Hive or Spark while Impala is reading them. In
the worst case, currently the refresh command fails which can be
retried by the user. However, this does not go well with when event
processing is turned on. EventProcessor tries to reload the table as
soon as it sees a INSERT_EVENT from metastore. Hive may be still
cleaning up the staging directories when EventProcessor issues a reload
causing it go in error state.

Ideally, we should have some sort of intra-engine synchronization
semantics to avoid such issues, but that is much more complex
architectural change. For now, we should ignore such errors and skip
the deleted file from being loaded.

Testing: Unfortunately, this error is hard to reproduce locally. I
tried creating multiple threads which delete some files while multiple
FileMetadataLoaders are loading concurrently but it didn't fail for me.
Ran TestEventProcessing.test_insert_events in a loop for 20 iterations
and didn't see any failure.

Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
1 file changed, 16 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/14806/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@9
PS1, Line 9: It is possible that when the file metadata of a table or partition is
> Could you please format the commit message to be 72 char width?
Done


http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@18
PS1, Line 18: soon as it sees a INSERT_EVENT from metastore. Hive may be still
> Should we retry the reload operation? I'm not sure whether this case is pos
I think this is a much harder problem to solve and would need a more integrated front end with Hive. In theory, hive could remove the files after load operation and it will still cause failures on the scanner side without a manual refresh. Just fixing this problem during load is not really going to help solve this issue completely. Also, there is a chance that we will keep reloading the table for a table which is updated by Hive at a high frequency.


http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@687
PS1, Line 687:           // instance, hive deletes the temporary files in the .hive-staging directory
> Is it possible that some removed files are loaded before so we end up with 
Unfortunately, its possible that the files once loaded are removed later. Currently, I don't see a good way to solve it without support from a integrated front-end across query engines.


http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@691
PS1, Line 691:           continue;
> Should we make this behavior configurable? This looks like a util that may 
The only place currently this class gets used is in FileMetadataLoader.load(). Not sure if its worth making it configurable. I can add a constructor which takes in a boolean to throw v/s continue if you think otherwise.



-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 Dec 2019 00:32:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@7
PS1, Line 7:  
nit: no space


http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@9
PS1, Line 9: It is possible that when the file metadata of a table or partition is being loaded, some
Could you please format the commit message to be 72 char width?
I add this config in my ~/.vimrc for this:

 filetype on
 au FileType gitcommit setlocal tw=72


http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@14
PS1, Line 14: the
nit: redundant


http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@18
PS1, Line 18: error state.
Should we retry the reload operation? I'm not sure whether this case is possible:
- Hive want to remove 10 files
- Load table operation has loaded 9 files
- Hive remove the 10 files
- Load table operation encounters FileNotFoundException for the last file and skipps it 

Then we have stale file meta for the 9 removed files, which may cause failures in the scanner side.


http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@687
PS1, Line 687:           // instance, hive deletes the temporary files in the .hive-staging directory
Is it possible that some removed files are loaded before so we end up with some stale metadata in this case?


http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@691
PS1, Line 691:           continue;
Should we make this behavior configurable? This looks like a util that may be used in many places. Not sure if any callers want to deal with the FileNotFoundException.



-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 30 Nov 2019 02:16:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14806/1//COMMIT_MSG@18
PS1, Line 18: soon as it sees a INSERT_EVENT from metastore. Hive may be still
> I think this is a much harder problem to solve and would need a more integr
OK, we can deal with it in the future if we want to let users get rid of REFRESH/INVALIDATE METADATA, though this is not the goal of event processor currently. Thanks for the explanation!


http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/14806/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@691
PS1, Line 691:           continue;
> The only place currently this class gets used is in FileMetadataLoader.load
OK, then I think we can make it configurable in the future if we really need.



-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 09:25:40 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5163/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Nov 2019 20:49:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9122 : Ignore FileNotFoundException when loading a table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14806 )

Change subject: IMPALA-9122 : Ignore FileNotFoundException when loading a table
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5241/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf6b193b0d57de27d41ad6ef6e1719005d9e908
Gerrit-Change-Number: 14806
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Dec 2019 19:46:09 +0000
Gerrit-HasComments: No