You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/22 21:12:33 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
grundprinzip opened a new pull request, #38762:
URL: https://github.com/apache/spark/pull/38762
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1029974156
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
+
+ def unpersist(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("unpersist() is not implemented.")
+
+ def cache(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("cache() is not implemented.")
+
+ def persist(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("persist() is not implemented.")
+
+ def withWatermark(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("withWatermark() is not implemented.")
+
+ def observe(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("observe() is not implemented.")
+
+ def foreach(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("foreach() is not implemented.")
+
+ def foreachPartition(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("foreachPartition() is not implemented.")
+
+ def toLocalIterator(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("toLocalIterator() is not implemented.")
+
+ def checkpoint(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("checkpoint() is not implemented.")
+
+ def localCheckpoint(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("localCheckpoint() is not implemented.")
+
Review Comment:
I think we also do not support `to_pandas_on_spark`, `pandas_api`, `registerTempTable `, `storageLevel`, `mapInPandas`, `mapInArrow `, `writeStream`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38762:
URL: https://github.com/apache/spark/pull/38762#issuecomment-1324244517
@HyukjinKwon @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1030519212
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
+
+ def unpersist(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("unpersist() is not implemented.")
+
+ def cache(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("cache() is not implemented.")
+
+ def persist(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("persist() is not implemented.")
+
+ def withWatermark(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("withWatermark() is not implemented.")
+
+ def observe(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("observe() is not implemented.")
+
+ def foreach(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("foreach() is not implemented.")
+
+ def foreachPartition(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("foreachPartition() is not implemented.")
+
+ def toLocalIterator(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("toLocalIterator() is not implemented.")
+
+ def checkpoint(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("checkpoint() is not implemented.")
+
+ def localCheckpoint(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("localCheckpoint() is not implemented.")
+
Review Comment:
ack will add those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1029983662
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
+
+ def unpersist(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("unpersist() is not implemented.")
+
+ def cache(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("cache() is not implemented.")
+
+ def persist(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("persist() is not implemented.")
+
+ def withWatermark(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("withWatermark() is not implemented.")
+
+ def observe(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("observe() is not implemented.")
+
+ def foreach(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("foreach() is not implemented.")
+
+ def foreachPartition(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("foreachPartition() is not implemented.")
+
+ def toLocalIterator(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("toLocalIterator() is not implemented.")
+
+ def checkpoint(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("checkpoint() is not implemented.")
+
+ def localCheckpoint(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("localCheckpoint() is not implemented.")
+
Review Comment:
+ `toJSON`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38762:
URL: https://github.com/apache/spark/pull/38762#issuecomment-1325822115
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1030519915
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
Review Comment:
While we might implement the others, here I want to be really specific about not being part of Spark Connect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1030952403
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
Review Comment:
Sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1030011493
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
Review Comment:
Maybe keep consistently to include `for Spark Connect` or not include in the error message?
Only this one mentions `Spark Connect` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38762:
URL: https://github.com/apache/spark/pull/38762#issuecomment-1325784550
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
URL: https://github.com/apache/spark/pull/38762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38762: [SPARK-41225] [CONNECT] [PYTHON] Disable unsupported functions.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38762:
URL: https://github.com/apache/spark/pull/38762#discussion_r1030011493
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -951,6 +951,39 @@ def createOrReplaceGlobalTempView(self, name: str) -> None:
).command(session=self._session)
self._session.execute_command(command)
+ def rdd(self, *args: Any, **kwargs: Any) -> None:
+ raise NotImplementedError("RDD Support for Spark Connect is not implemented.")
Review Comment:
Maybe keep consistently to include `for Spark Connect` or not include it in the error message?
Either is fine.
Only this one mentions `Spark Connect` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org