You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by di...@apache.org on 2026/10/20 14:10:31 UTC

(polaris) branch main updated: Build: remove unused variables in settings.gradle.kts (#5825)

This is an automated email from the ASF dual-hosted git repository.

dimas-b pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new 417a0fb9da Build: remove unused variables in settings.gradle.kts (#5825)
417a0fb9da is described below

commit 417a0fb9da26bed580226b3e71c1fb311f6d28a4
Author: Seungchul Lee <sc...@gmail.com>
AuthorDate: Tue Oct 20 23:10:25 2026 +0900

    Build: remove unused variables in settings.gradle.kts (#5825)
    
    `first` became unused in #4775, when the handling of duplicated
      Spark project sources moved to `noSourceCheckProjects` in
      build-logic. `projects` has never been referenced.
    
      No functional change: `./gradlew projects` output is identical.
---
 settings.gradle.kts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/settings.gradle.kts b/settings.gradle.kts
index b7e2cfc051..9b2224bb09 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -78,8 +78,6 @@ fun polarisProject(name: String, directory: File) {
   prj.projectDir = file(directory)
 }
 
-val projects = Properties()
-
 loadProperties(file("gradle/projects.main.properties")).forEach { name, directory ->
   polarisProject(name as String, file(directory as String))
 }
@@ -97,15 +95,11 @@ for (sparkVersion in sparkVersions) {
   val scalaVersionsKey = "scalaVersions.${sparkVersion}"
   val scalaVersionsStr = sparkScalaVersions[scalaVersionsKey].toString()
   val scalaVersions = scalaVersionsStr.split(",").map { it.trim() }
-  var first = true
   for (scalaVersion in scalaVersions) {
     polarisProject(
       "polaris-spark-${sparkVersion}_${scalaVersion}",
       file("${polarisSparkDir}/v${sparkVersion}/spark"),
     )
-    if (first) {
-      first = false
-    }
     // Skip all duplicated spark client projects in IDE imports.
     // This is to avoid problems during dependency analysis and sync, like
     // "Multiple projects in this build are located in the same directory".