[GitHub] [arrow-rs] viirya commented on a diff in pull request #4692: Support references in i256 arithmetic ops

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #4692:
URL: https://github.com/apache/arrow-rs/pull/4692#discussion_r1293874627


##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -659,6 +659,48 @@ macro_rules! derive_op {
                 self.$wrapping(rhs)
             }
         }
+
+        impl<'a> std::ops::$t<i256> for &'a i256 {
+            type Output = i256;
+
+            #[cfg(debug_assertions)]

Review Comment:
   I think we don't have dereference implementation for i256? Or I misunderstand your comment?
   
   ```
   error[E0614]: type `bigint::i256` cannot be dereferenced
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org