You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/30 03:25:44 UTC
[GitHub] [rocketmq] RookieRoll opened a new pull request #3678: Fix param spelling error
RookieRoll opened a new pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678
spelling error
**Make sure set the target branch to `develop`**
## What is the purpose of the change
fix class[RemotingHelper] method[exceptionSimpleDesc] var[element] spelling error
## Brief changelog
fix class[RemotingHelper] method[exceptionSimpleDesc] var[element] spelling error
## Verifying this change
fix class[RemotingHelper] method[exceptionSimpleDesc] var[element] spelling error
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling merged pull request #3678: [ISSUE #3685] Fix param spelling error
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll removed a comment on pull request #3678: Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll removed a comment on pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#issuecomment-1003276113
I added an issue
https://github.com/apache/rocketmq/issues/3685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll commented on a change in pull request #3678: [ISSUE #3685] Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll commented on a change in pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#discussion_r778576685
##########
File path: .travis.yml
##########
@@ -4,8 +4,10 @@ notifications:
email:
recipients:
- dev@rocketmq.apache.org
+ if: branch = develop OR branch = master
Review comment:
Do you need me to pull a branch from develop and resubmit it without this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll commented on pull request #3678: Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll commented on pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#issuecomment-1003276242
> @RookieRoll Would you like to submit an issue first?
I added an issue
https://github.com/apache/rocketmq/issues/3685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll commented on pull request #3678: Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll commented on pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#issuecomment-1003276163
> @RookieRoll Would you like to submit an issue first?
I added an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on pull request #3678: Fix param spelling error
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#issuecomment-1003256620
@RookieRoll Would you like to submit an issue first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll commented on pull request #3678: Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll commented on pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#issuecomment-1003276113
I added an issue
https://github.com/apache/rocketmq/issues/3685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll removed a comment on pull request #3678: Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll removed a comment on pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#issuecomment-1003276163
> @RookieRoll Would you like to submit an issue first?
I added an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RookieRoll commented on a change in pull request #3678: [ISSUE #3685] Fix param spelling error
Posted by GitBox <gi...@apache.org>.
RookieRoll commented on a change in pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#discussion_r778574733
##########
File path: .travis.yml
##########
@@ -4,8 +4,10 @@ notifications:
email:
recipients:
- dev@rocketmq.apache.org
+ if: branch = develop OR branch = master
Review comment:
en,not my changed ,i check out this feature from master, this changed is in master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy commented on a change in pull request #3678: [ISSUE #3685] Fix param spelling error
Posted by GitBox <gi...@apache.org>.
caigy commented on a change in pull request #3678:
URL: https://github.com/apache/rocketmq/pull/3678#discussion_r778547247
##########
File path: .travis.yml
##########
@@ -4,8 +4,10 @@ notifications:
email:
recipients:
- dev@rocketmq.apache.org
+ if: branch = develop OR branch = master
Review comment:
Why changing this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org