You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Robert Munteanu (JIRA)" <ji...@apache.org> on 2014/06/13 15:40:02 UTC
[jira] [Commented] (SLING-3653) 'Child node ordering not supported'
when republishing tree
[ https://issues.apache.org/jira/browse/SLING-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030623#comment-14030623 ]
Robert Munteanu commented on SLING-3653:
----------------------------------------
While this fixes the issue, I believe the we need to adjust it a bit. The reorderChildNodes call should be done since other child nodes down the path are potentially orderable. This can happen for nodes with full coverage and with more than one level of children.
I'll work on more tests to demonstrate the correct behaviour.
> 'Child node ordering not supported' when republishing tree
> ----------------------------------------------------------
>
> Key: SLING-3653
> URL: https://issues.apache.org/jira/browse/SLING-3653
> Project: Sling
> Issue Type: Bug
> Components: IDE
> Reporter: Stefan Egli
> Assignee: Robert Munteanu
> Fix For: Sling Eclipse IDE 1.0.0
>
>
> Consider the following content:
> {code}
> \- someNode [nt:unstructured]
> \- someChild [sling:Folder]
> |- someGrandChild1 [nt:unstructured]
> \- someGrandChild2 [nt:unstructured]
> {code}
> When re-uploading such a structure (using the 'clean and publish...' mechanism), it fails with the following message:
> {code}
> org.apache.sling.ide.transport.RepositoryException: javax.jcr.UnsupportedRepositoryOperationException: Child node ordering not supported on node /content/theappy/home/jcr:content
> at org.apache.sling.ide.impl.vlt.JcrResult.failure(JcrResult.java:33)
> at org.apache.sling.ide.impl.vlt.JcrCommand.execute(JcrCommand.java:62)
> at org.apache.sling.ide.transport.TracingCommand.execute(TracingCommand.java:43)
> at org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.execute(SlingLaunchpadBehaviour.java:392)
> at org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishContentModule(SlingLaunchpadBehaviour.java:370)
> at org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishModule(SlingLaunchpadBehaviour.java:188)
> at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1091)
> at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1183)
> at org.apache.sling.ide.eclipse.core.internal.ServerBehaviourDelegateWithModulePublishSupport.publish(ServerBehaviourDelegateWithModulePublishSupport.java:137)
> at org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
> at org.apache.sling.ide.eclipse.core.internal.ServerBehaviourDelegateWithModulePublishSupport.publish(ServerBehaviourDelegateWithModulePublishSupport.java:54)
> at org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3154)
> at org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:345)
> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> Caused by: javax.jcr.UnsupportedRepositoryOperationException: Child node ordering not supported on node /content/theappy/home/jcr:content
> at org.apache.jackrabbit.jcr2spi.NodeImpl.orderBefore(NodeImpl.java:198)
> at org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.reorderChildNodes(AddOrUpdateNodeCommand.java:192)
> at org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.reorderChildNodes(AddOrUpdateNodeCommand.java:184)
> at org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.update(AddOrUpdateNodeCommand.java:119)
> at org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.execute0(AddOrUpdateNodeCommand.java:80)
> at org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.execute0(AddOrUpdateNodeCommand.java:1)
> at org.apache.sling.ide.impl.vlt.JcrCommand.execute(JcrCommand.java:54)
> ... 12 more
> {code}
> The problem seems to be caused by the iteration in reorderChildNodes, which no longer takes 'orderable' into account
--
This message was sent by Atlassian JIRA
(v6.2#6252)