[jira] [Commented] (OAK-5025) Speed up ACE node name generation

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15676288#comment-15676288 ] 

angela commented on OAK-5025:
-----------------------------

cool stuff, thanks a lot. I will take a closer look today and run the benchmarks.

> Speed up ACE node name generation
> ---------------------------------
>
>                 Key: OAK-5025
>                 URL: https://issues.apache.org/jira/browse/OAK-5025
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.5.12
>            Reporter: Alex COLLIGNON
>            Assignee: angela
>            Priority: Minor
>              Labels: performance
>             Fix For: 1.6
>
>         Attachments: OAK-5025-ACE-name-generation-benchmarks.patch, OAK-5025-ACE-random-nodename-generation.patch
>
>
> Currently, {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is traversing all the existing ACE of a certain node in order to generate continuous numbering (allow0, allow1, allow2).
> While that certainly helps to produce human readable names, it represents quite a performance bottleneck when the number of existing ACE starts to grow.
> Since the naming is a pure implementation detail, my proposal is to keep the continuous numbering for the first hundreds of nodes and then use a random number to generate unique names in a faster fashion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)