You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/10 00:48:11 UTC
[PR] fix(metrics): enforce instance data source bindings [rocketmq-dashboard]
btlqql opened a new pull request, #1373:
URL: https://github.com/apache/rocketmq-dashboard/pull/1373
## Summary
- carry the selected managed-instance ID through Metrics Explorer and the data-source query API
- enforce persisted `instanceIds` bindings in `MetricsService` before constructing or contacting a metrics backend
- keep unbound data sources globally available while rejecting missing or mismatched instances with a structured HTTP 400
- add service, controller, API-client, and component regression coverage for the full contract
## Root cause
The browser filtered the data-source selector, but the query request contained only the source key. A caller could bypass the UI and query a source bound to a different managed instance because the server never evaluated `DataSourceVO.instanceIds`.
## Validation
- `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home mvn -q -DskipTests=false -Dtest=MetricsServiceTest,MetricsControllerTest test`
- `NODE_OPTIONS=--no-experimental-webstorage npm test -- --run src/api/metrics.test.ts src/components/__tests__/MetricsExplorer.test.tsx`
- `NODE_OPTIONS=--no-experimental-webstorage npx eslint src/api/metrics.ts src/api/metrics.test.ts src/components/MetricsExplorer.tsx src/components/__tests__/MetricsExplorer.test.tsx --quiet`
- `NODE_OPTIONS=--no-experimental-webstorage npm run build`
Fixes #1260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(metrics): enforce instance data source bindings [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1373:
URL: https://github.com/apache/rocketmq-dashboard/pull/1373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org