You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/09/01 09:16:38 UTC
Re: Review Request 61849: Improved consistency of cout/cerr and glog
usage in main functions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61849/#review184345
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Aug. 31, 2017, 4:39 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61849/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 4:39 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
>
>
> Bugs: MESOS-7586
> https://issues.apache.org/jira/browse/MESOS-7586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The main functions now have a common initialization pattern:
> 1. Load flags.
> 2. Check if the --help flag has been passed.
> 3. Check if the flags are correct.
> 4. Initialize logging.
> 5. Parse and setup the environment variables.
> 6. Initialize libprocess.
>
> This change reduces the number of messages "WARNING: Logging before
> InitGoogleLogging() is written to STDERR" as we now use glog only after
> the fourth step. This forces all glog messages to end up in a logdir.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp aff97939b088e3747111ca6ec00fe76c59e9b396
> src/launcher/default_executor.cpp 30bae5c931c81b81ff9590eea8051b2232388813
> src/launcher/executor.cpp 65b9a2c52ba5a5a514fff992018e356f388468fc
> src/local/main.cpp f0d7e8ca1a64b5409632ea0c0894a1dc84f9796e
> src/master/main.cpp 1a78a55fd52c5eebad689c2a7f16c95979260d79
> src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7
>
>
> Diff: https://reviews.apache.org/r/61849/diff/6/
>
>
> Testing
> -------
>
> ```
> $ make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>