You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/08/02 12:48:00 UTC

[jira] [Commented] (HBASE-24805) HBaseTestingUtility.getConnection should be threadsafe

    [ https://issues.apache.org/jira/browse/HBASE-24805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169536#comment-17169536 ] 

Hudson commented on HBASE-24805:
--------------------------------

Results for branch master
	[build #1801 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/General_20Nightly_20Build_20Report/]






(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1801/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for details|https://builds.apache.org/job/HBase%20Nightly/job/master/1801//artifact/output-integration/hadoop-2.log]. (note that this means we didn't run on Hadoop 3)


> HBaseTestingUtility.getConnection should be threadsafe
> ------------------------------------------------------
>
>                 Key: HBASE-24805
>                 URL: https://issues.apache.org/jira/browse/HBASE-24805
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>
> the current javadoc for getConnection carries a thread safety warning:
> {code}
> /**
>     * Get a Connection to the cluster. Not thread-safe (This class needs a lot of work to make it
>     * thread-safe).
>     * @return A Connection that can be shared. Don't close. Will be closed on shutdown of cluster.
>     */
>    public Connection getConnection() throws IOException {
> {code}
> We then ignore that warning across our test base. We should make the method threadsafe since the intention is to share a single Connection across all users of the HTU instance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)