[jira] Issue Comment Edited: (LUCENE-1487) FieldCacheTermsFilter

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723098#action_12723098 ] 

Uwe Schindler edited comment on LUCENE-1487 at 6/23/09 8:28 AM:
----------------------------------------------------------------

Sorry *EDIT*:
This Filter is really cool on iterating on the FieldCache for StringIndex and can be even faster for ranges, that are int/float/double/... - so why not retrofit to our new naming-convention and extend:

- FieldCacheRangeFilter.newTermRange()
- FieldCacheRangeFilter.newByteRange()
- FieldCacheRangeFilter.newShortRange()
- FieldCacheRangeFilter.newIntRange()
- ...

It could because of that also be used on "old" int/long fields of dates, if a good parser is given (parser that does SimpleDateFormat -> long -> FieldCache -> direct comparison on this raw numbers). I would try to extend this to all types and it can be faster than TrieRange, if the range is already in FieldCache!

      was (Author: thetaphi):
    Is this Filter really needed anymore?

If yes, why not create an FieldCacheRangeFilter that can handle any data type from FieldCache:

- FieldCacheRangeFilter.newTermRange()
- FieldCacheRangeFilter.newByteRange()
- FieldCacheRangeFilter.newShortRange()
- FieldCacheRangeFilter.newIntRange()
- ...
  
> FieldCacheTermsFilter
> ---------------------
>
>                 Key: LUCENE-1487
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1487
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>    Affects Versions: 2.4
>            Reporter: Tim Sturge
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: FieldCacheTermsFilter.java, FieldCacheTermsFilter.java, LUCENE-1487.patch
>
>
> This is a companion to FieldCacheRangeFilter except it operates on a set of terms rather than a range. It works best when the set is comparatively large or the terms are comparatively common.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org