You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Brandon Li (JIRA)" <ji...@apache.org> on 2012/09/15 22:21:07 UTC
[jira] [Created] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Brandon Li created HADOOP-8814:
----------------------------------
Summary: Inefficient comparison with the empty string. Use isEmpty() instead
Key: HADOOP-8814
URL: https://issues.apache.org/jira/browse/HADOOP-8814
Project: Hadoop Common
Issue Type: Improvement
Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
Reporter: Brandon Li
Assignee: Brandon Li
Priority: Minor
Prior to JDK 6, we can check if a string is empty in 2 ways:
* if(s != null && s.length() == 0)
* if(("").equals(s)) or if( s.equals(""))
Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459340#comment-13459340 ]
Hudson commented on HADOOP-8814:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2771 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2771/])
HADOOP-8814. Replace string equals by String#isEmpty(). Contributed by Brandon Li. (Revision 1387853)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387853
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458149#comment-13458149 ]
Brandon Li commented on HADOOP-8814:
------------------------------------
Thanks Suresh for reviewing it.
Yes, somestring.isEmpty() is not identical to "".equals(somestring). However, in the context where "".equals(somestring) is replaced with somestring.isEmpty, there is the assumption that somestring is not null.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459326#comment-13459326 ]
Hudson commented on HADOOP-8814:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2811 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2811/])
HADOOP-8814. Replace string equals by String#isEmpty(). Contributed by Brandon Li. (Revision 1387853)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387853
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459608#comment-13459608 ]
Hudson commented on HADOOP-8814:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1202 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1202/])
HADOOP-8814. Replace string equals by String#isEmpty(). Contributed by Brandon Li. (Revision 1387853)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387853
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HADOOP-8814) Inefficient comparison with
the empty string. Use isEmpty() instead
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456678#comment-13456678 ]
Suresh Srinivas edited comment on HADOOP-8814 at 9/17/12 8:31 AM:
------------------------------------------------------------------
Comments:
{noformat}
- if ("".equals(filename) || Path.SEPARATOR.equals(filename)) {
+ if (filename.isEmpty() || Path.SEPARATOR.equals(filename)) {
{noformat}
In this case the previous check {{"".equals(name)}} returned true for only "" and returned false for null. In the new code NPE will be thrown. So please do appropriate changes in the patch.
That said, I agree that {{isEmpty()}} looking at javacode seems to more efficient.
was (Author: sureshms):
Brandon, I am not sure this is a straight forward change. For example:
{noformat}
- if ("".equals(filename) || Path.SEPARATOR.equals(filename)) {
+ if (filename.isEmpty() || Path.SEPARATOR.equals(filename)) {
{noformat}
In this case the previous check {{"".equals(filename}}} returned true for only "" and return false for null. In the new code a NPE will be thrown. So please do appropriate changes in the patch.
That said, I agree that isEmpty looking at javacode seems to more efficient.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456493#comment-13456493 ]
Hadoop QA commented on HADOOP-8814:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545290/HADOOP-8814.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.util.TestStringUtils
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1471//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/1471//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1471//console
This message is automatically generated.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459297#comment-13459297 ]
Brandon Li commented on HADOOP-8814:
------------------------------------
Yes. I missed that one. :-(
Thanks! Fixed in the new patch.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459574#comment-13459574 ]
Hudson commented on HADOOP-8814:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1171 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1171/])
HADOOP-8814. Replace string equals by String#isEmpty(). Contributed by Brandon Li. (Revision 1387853)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387853
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8814:
-------------------------------
Attachment: HADOOP-8814.patch
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459302#comment-13459302 ]
Hadoop QA commented on HADOOP-8814:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545838/HADOOP-8814.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1488//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1488//console
This message is automatically generated.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459330#comment-13459330 ]
Hudson commented on HADOOP-8814:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2748 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2748/])
HADOOP-8814. Replace string equals by String#isEmpty(). Contributed by Brandon Li. (Revision 1387853)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387853
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurationServlet.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DefaultStringifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/TFile.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordInput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/record/CsvRecordOutput.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenIdentifier.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HostsFileReader.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8814:
-------------------------------
Attachment: HADOOP-8814.patch
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459286#comment-13459286 ]
Suresh Srinivas commented on HADOOP-8814:
-----------------------------------------
ok, that makes sense.
Patch looks good, except, In StringUtils.java - previous code had str.trim(). New code does not have it
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8814:
-------------------------------
Status: Patch Available (was: Open)
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8814:
-------------------------------
Status: Open (was: Patch Available)
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8814:
-------------------------------
Description:
Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
was:
Prior to JDK 6, we can check if a string is empty in 2 ways:
* if(s != null && s.length() == 0)
* if(("").equals(s)) or if( s.equals(""))
Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456678#comment-13456678 ]
Suresh Srinivas commented on HADOOP-8814:
-----------------------------------------
Brandon, I am not sure this is a straight forward change. For example:
{noformat}
- if ("".equals(filename) || Path.SEPARATOR.equals(filename)) {
+ if (filename.isEmpty() || Path.SEPARATOR.equals(filename)) {
{noformat}
In this case the previous check {{"".equals(filename}}} returned true for only "" and return false for null. In the new code a NPE will be thrown. So please do appropriate changes in the patch.
That said, I agree that isEmpty looking at javacode seems to more efficient.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Li updated HADOOP-8814:
-------------------------------
Status: Patch Available (was: Open)
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8814) Inefficient comparison with the
empty string. Use isEmpty() instead
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8814:
------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch to trunk.
> Inefficient comparison with the empty string. Use isEmpty() instead
> -------------------------------------------------------------------
>
> Key: HADOOP-8814
> URL: https://issues.apache.org/jira/browse/HADOOP-8814
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf, fs, fs/s3, ha, io, metrics, performance, record, security, util
> Reporter: Brandon Li
> Assignee: Brandon Li
> Priority: Minor
> Attachments: HADOOP-8814.patch, HADOOP-8814.patch
>
>
> Prior to JDK 6, we can check if a string is empty by doing "".equals(s) or s.equals("").
> Starting from JDK 6, String class has a new convenience and efficient method isEmpty() to check string's length.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira