You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2016/04/06 10:04:25 UTC
[jira] [Comment Edited] (QPIDJMS-169) SASL Plain Mechanism should
be enforcing UTF-8 encoding
[ https://issues.apache.org/jira/browse/QPIDJMS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227915#comment-15227915 ]
Keith Wall edited comment on QPIDJMS-169 at 4/6/16 8:03 AM:
------------------------------------------------------------
Hi Tim,
I am not sure about this change. The old implementation was platform dependent and certainly wrong, but SASL requires that usernames/passwords are sasl-preped[1] which defines a character mapping. My reading of the RFCs is that this applies to SASL PLAIN too.
org.apache.qpid.jms.sasl.AbstractScramSHAMechanism#saslPrep is a noddy implementation which side steps most of the requirements by restricting the usernames/passwords to ASCII. I think org.apache.qpid.jms.sasl.PlainMechanism should at least do the same, or we should switch to a real saslprep algorithm, but the latter should be coordinated across all the components.
[1] https://www.ietf.org/rfc/rfc4013.txt
was (Author: k-wall):
Hi Tim,
I am not sure about this change. The old implementation was platform dependent and certainly wrong, but SASL requires that usernames/passwords are salsa-preped[1] which defines a character mapping. My reading of the RFCs is that this applies to SASL PLAIN too.
org.apache.qpid.jms.sasl.AbstractScramSHAMechanism#saslPrep is a noddy implementation which side steps most of the requirements by restricting the usernames/passwords to ASCII. I think org.apache.qpid.jms.sasl.PlainMechanism should at least do the same, or we should switch to a real saslprep algorithm, but the latter should be coordinated across all the components.
[1] https://www.ietf.org/rfc/rfc4013.txt
> SASL Plain Mechanism should be enforcing UTF-8 encoding
> -------------------------------------------------------
>
> Key: QPIDJMS-169
> URL: https://issues.apache.org/jira/browse/QPIDJMS-169
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Affects Versions: 0.8.0
> Reporter: Timothy Bish
> Assignee: Timothy Bish
> Fix For: 0.9.0
>
>
> When encoding the user / pass in the SASL plain mechanism we aren't enforcing UTF-8 encoding which is the required encoding.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org