You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2018/10/19 16:00:15 UTC
[Bug 62839] New: MathX.floor for negative n
https://bz.apache.org/bugzilla/show_bug.cgi?id=62839
Bug ID: 62839
Summary: MathX.floor for negative n
Product: POI
Version: 4.0.0-FINAL
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: SS Common
Assignee: dev@poi.apache.org
Reporter: poi@table2web.de
Target Milestone: ---
Behavior in LibreOffice / Excel:
The result of function call FLOOR.XCL(-123;10) in LibreOffice 6.1.2.1 is -130.
The result in Excel Office 365 is also -130.
The result in POI 4.0.0 via cell.getNumericCellValue() is -130.0.
Problem:
The result of new DataFormatter().formatCellValue(cell, formulaEvaluator) is
#NUM!.
Expected result:
I suppose that the result in POI also should be -130.
Idea for improvement:
Remove the condition (n<0 && s>0) in the if-statement in
org.apache.poi.ss.formula.functions.MathX.floor(double, double)
And I suggest that the condition (s==0 && n!=0) in
org.apache.poi.ss.formula.functions.MathX.floor(double, double) could be
removed also. Excel returns 0 for floor(0;10) and LibreOffice also returns 0.
I guess that org.apache.poi.ss.formula.functions.MathX.ceiling(double, double)
has already been changed this way, because the docs tell about negative n, but
the if-statement does not check that.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62839] MathX.floor for negative n
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62839
--- Comment #2 from Sven <po...@table2web.de> ---
Thank you! :-)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 62839] MathX.floor for negative n
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62839
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
Fixed via r1849764.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org