You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/09 03:28:47 UTC
[GitHub] [airflow] wolfier opened a new pull request #15299: Synchronize the commiter list (#15292)
wolfier opened a new pull request #15299:
URL: https://github.com/apache/airflow/pull/15299
closes: #14394
I was only able to link python classes that are defined in `apache-airflow`.
Not sure how to link them with classes that are defined in providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on a change in pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
wolfier commented on a change in pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#discussion_r611096602
##########
File path: airflow/contrib/sensors/file_sensor.py
##########
@@ -15,7 +15,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""This module is deprecated. Please use `airflow.sensors.filesystem`."""
+"""This module is deprecated. Please use :class:`airflow.sensors.filesystem`."""
Review comment:
I didn't realize they were referencing modules. I'll use that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#issuecomment-817129412
> Not sure how to link them with classes that are defined in providers.
It should work normally e.g. ``:class:`airflow.providers.google.cloud.operators.kubernetes_engine` `` See also: https://github.com/apache/airflow/blob/master/docs/apache-airflow/concepts.rst#operators (operators section)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#discussion_r611092164
##########
File path: airflow/contrib/sensors/file_sensor.py
##########
@@ -15,7 +15,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""This module is deprecated. Please use `airflow.sensors.filesystem`."""
+"""This module is deprecated. Please use :class:`airflow.sensors.filesystem`."""
Review comment:
Docs for it: https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#cross-referencing-python-objects
The default language is `python` so you can use `:py:mod:` or just `:mod:`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #15299: Synchronize the commiter list (#15292)
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#issuecomment-816375376
@jhtimmins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#issuecomment-816788322
@kaxil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#issuecomment-817214810
Accidentally edited another commit with amend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier closed pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
wolfier closed pull request #15299:
URL: https://github.com/apache/airflow/pull/15299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15299: Add link to not deprecated modules docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15299:
URL: https://github.com/apache/airflow/pull/15299#discussion_r611092116
##########
File path: airflow/contrib/sensors/file_sensor.py
##########
@@ -15,7 +15,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-"""This module is deprecated. Please use `airflow.sensors.filesystem`."""
+"""This module is deprecated. Please use :class:`airflow.sensors.filesystem`."""
Review comment:
```suggestion
"""This module is deprecated. Please use :mod:`airflow.sensors.filesystem`."""
```
Since this is a module and not class, same for all other cases too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org