You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 19:58:00 UTC

[GitHub] [superset] kevinwenglu commented on issue #15729: Modifying a connection's meta data not working after creation

kevinwenglu commented on issue #15729:
URL: https://github.com/apache/superset/issues/15729#issuecomment-881684143


   There is no actual trace stack on the page because the frontend captures that and display as an error message, but the screenshot shows the stack until the exception is raised.
   As I said, we captured the master in May. I haven’t had time to test 1.2 yet, but seems like the logic is the same. I also see that the superset/databases/schemas.py in 1.3 and the current master is using the different condition to check against the validity of the engine spec.
   https://github.com/apache/superset/blob/master/superset/databases/schemas.py
   https://github.com/apache/superset/blob/1.3/superset/databases/schemas.py
   https://github.com/apache/superset/blob/1.2/superset/databases/schemas.py
   
   ![Screen Shot 2021-07-16 at 12 42 54 PM](https://user-images.githubusercontent.com/81392331/126002064-20958d1e-1b91-4d1f-a058-8b3896e85a1a.png)
   ![Screen Shot 2021-07-16 at 12 45 54 PM](https://user-images.githubusercontent.com/81392331/126002078-4cc0e615-f849-4b07-b6b5-fcf50304754e.png)
   [superset.databases.schemas.in_may.py.txt](https://github.com/apache/superset/files/6833085/superset.databases.schemas.in_may.py.txt)
   [superset.databases.schemas.1.2.py.txt](https://github.com/apache/superset/files/6833086/superset.databases.schemas.1.2.py.txt)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org