[GitHub] [beam] AydarZaynutdinov commented on pull request #14856: [BEAM-11873] Add support for writes with returning values in JdbcIO

[GitBox <gi...@apache.org>]

AydarZaynutdinov commented on pull request #14856:
URL: https://github.com/apache/beam/pull/14856#issuecomment-907130750


   Thanks @aromanenko-dev. As I understood I should:
   - rename method `withReturningResults()` to `withWriteResults()`.
   - keep old method with name `withResults()` (do not rename it to `withVoidResults`).
   - change back `private` to `public` access for `writeVoid` method.
   
   About other discussions:
   - [records by batches](https://github.com/apache/beam/pull/14856#discussion_r644967332). As I understood Vitaliy gave clarify answer why he had used `execute()` method instead of `executeBatch()`. So I guess I should leave it like it is now -> use `execute()`.
   -  [wrap up `V`](https://github.com/apache/beam/pull/14856#discussion_r644964072). I'm not sure that we need this wraping, becaus a new abstract class `JdbcWriteResult` will no have any rules or parameters and as a result it would be just a empty class. May be it would be better transform `JdbcWriteResult` to empty interface? So it would be like a marker for each`V`. Could you please share your thoughts?
   
   Is there anything else I should address?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org