You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/31 14:33:34 UTC

[GitHub] [incubator-doris] xinyiZzz opened a new pull request, #9894: [Enhancement] Remove minidump

xinyiZzz opened a new pull request, #9894:
URL: https://github.com/apache/incubator-doris/pull/9894

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Minidump is not useful in a real online environment, instead it introduces additional errors.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] yiguolei merged pull request #9894: [Enhancement] Remove minidump

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9894:
URL: https://github.com/apache/incubator-doris/pull/9894


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] xinyiZzz commented on pull request #9894: [Enhancement] Remove minidump

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #9894:
URL: https://github.com/apache/incubator-doris/pull/9894#issuecomment-1142277927

   > Does we should remove `breakpad`?
   
   done, you are right


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9894: [Enhancement] Remove minidump

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9894:
URL: https://github.com/apache/incubator-doris/pull/9894#issuecomment-1142236383

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #9894: [Enhancement] Remove minidump

Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #9894:
URL: https://github.com/apache/incubator-doris/pull/9894#issuecomment-1142240589

   Does we should remove `breakpad`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] gaodayue commented on pull request #9894: [Enhancement] Remove minidump

Posted by GitBox <gi...@apache.org>.
gaodayue commented on PR #9894:
URL: https://github.com/apache/incubator-doris/pull/9894#issuecomment-1145414782

   > Minidump is not useful in a real online environment, instead it introduces additional errors.
   
   @xinyiZzz What is the additional errors introduced by minidump? I think minidump is still useful in scenarios where coredump is too large to be enabled, what's the alternative to minidump in those scenarios?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9894: [Enhancement] Remove minidump

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9894:
URL: https://github.com/apache/incubator-doris/pull/9894#issuecomment-1142236426

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org