You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "jay wong (JIRA)" <ji...@apache.org> on 2014/04/09 07:59:14 UTC

[jira] [Created] (PHOENIX-921) KeyValue check in MetaDataEndpointImpl#addColumnToTable is not sufficiency

jay wong created PHOENIX-921:
--------------------------------

             Summary: KeyValue check in MetaDataEndpointImpl#addColumnToTable  is not sufficiency
                 Key: PHOENIX-921
                 URL: https://issues.apache.org/jira/browse/PHOENIX-921
             Project: Phoenix
          Issue Type: Bug
    Affects Versions: 3.0.0
            Reporter: jay wong
             Fix For: 3.0.0


In my using.
when I create a table with no Index.

the method MetaDataEndpointImpl#addColumnToTable

the code like:
-------
 Integer maxLength = columnSizeKv == null ? null : PDataType.INTEGER.getCodec().decodeInt(columnSizeKv.getBuffer(), columnSizeKv.getValueOffset(), SortOrder.getDefault());
-------

didn't check the columnSizeKv length is 0. if 0, the decodeInt will throw exception. 

so I think it will be check like this:

Integer maxLength = columnSizeKv == null || columnSizeKv .getValue().length == 0 ? null : PDataType.INTEGER.getCodec().decodeInt(columnSizeKv.getBuffer(), columnSizeKv.getValueOffset(), SortOrder.getDefault());





--
This message was sent by Atlassian JIRA
(v6.2#6252)