You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/19 03:11:17 UTC
[GitHub] sunjincheng121 commented on a change in pull request #7121:
[FLINK-9555]Support table api in scala shell
sunjincheng121 commented on a change in pull request #7121: [FLINK-9555]Support table api in scala shell
URL: https://github.com/apache/flink/pull/7121#discussion_r234481358
##########
File path: flink-dist/pom.xml
##########
@@ -319,7 +319,6 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-table_${scala.binary.version}</artifactId>
<version>${project.version}</version>
- <scope>provided</scope>
Review comment:
I suggest that revert this change, because `flink-dist` is the whole release strategy of flink. At present, we package the `flink-table` module to the `opt` directory. The minimum change I suggest is to modify the scala-shell CLASSPATH and include `opt/opt/flink-tableXXX.jar` in the CLASSPATH， to support tables in `scala-shell`, What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services