[GitHub] [incubator-druid] mcbrewster opened a new pull request #7669: add tests to dialogs, compnents and views. Add index files to compone…

[GitBox <gi...@apache.org>]

mcbrewster opened a new pull request #7669: add tests to dialogs, compnents and views. Add index files to compone…
URL: https://github.com/apache/incubator-druid/pull/7669
 
 
   …nts and dialogs. add nested file structure
   
   <img width="682" alt="Screen Shot 2019-05-15 at 6 29 10 PM" src="https://user-images.githubusercontent.com/37322608/57820019-d9122200-773f-11e9-9f9a-c970fe966ce8.png">
   The main purpose of this code is to add snapshot testing to the web console. A snapshot test takes the component that it is testing, renders it, and then takes a snapshot of what the component should look like. Unintentional changes to the UI should cause the test to fail. The tests can be run with the command jest, or updated with the command update. 
   
   The dialogs and components use react-testing-library, while the views use Enzyme testing library. This is so the views can use a shallow render, that only renders the components one level deep allowing it to run faster. 
   
   Additionally, the file structure of views, dialogs, and components has been changed so that the snapshot, the test spec and the component code are all in the same file. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org