You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2015/01/06 04:48:34 UTC

[jira] [Commented] (OFBIZ-5948) Form Widget doesn't use thead or tbody with list forms

    [ https://issues.apache.org/jira/browse/OFBIZ-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265651#comment-14265651 ] 

Adrian Crum commented on OFBIZ-5948:
------------------------------------

Please use a plain diff file. We can't apply Git diff files.

> Form Widget doesn't use thead or tbody with list forms
> ------------------------------------------------------
>
>                 Key: OFBIZ-5948
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5948
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Chris Howe
>            Priority: Minor
>         Attachments: renderTheadTbodyId.patch
>
>
> The form widget for type list uses tr with a class of header-row and no thead element.  There are 23 instances of the thead element in ftl files.
> The form widget also does not use tbody element.  There are 38 instances of it being used in ftl files.
> CSS to utilize the '.header row th' selector in addition to the '.header-row td' selector in the flat_grey theme is also added.
> Also, the htmlFormMacroLibrary wasn't adding the id element for the table.
> The attached patch creates this for the HtmlFormRenderer and the MacroFormRenderer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)