You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 16:39:28 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31897: [SPARK-34776][SQL] Nested column pruning should not prune Window produced attributes

dongjoon-hyun commented on a change in pull request #31897:
URL: https://github.com/apache/spark/pull/31897#discussion_r597823147



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -670,6 +670,8 @@ case class Window(
   override def output: Seq[Attribute] =
     child.output ++ windowExpressions.map(_.toAttribute)
 
+  override def producedAttributes: AttributeSet = windowOutputSet

Review comment:
       BTW, isn't this a bug of `Window` class implementation itself, @viirya ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org